Improve references - Githubissues

huridocs / uwazi

Uwazi is a web-based, open-source solution for building and sharing document collections

http://www.uwazi.io

MIT License

236 stars 79 forks source link

Improve references #7084

Closed Zasa-san closed 1 month ago

Zasa-san commented 1 month ago

PR checklist:

[ ] Update READ.me ?
[ ] Update API documentation ?

QA checklist:

[ ] Smoke test the functionality described in the issue
[ ] Test for side effects
[ ] UI responsiveness
[ ] Cross browser testing
[ ] Code review

konzz commented 1 month ago

My only comment would be that to refactor activateReference to instead of receiving 5 arguments, expect some of the arguments as in an options object, like the delayActivation or showContextMenu because I see that in different scenarios you had to pass "undefined" arguments to pass the last argument. But also I can see that the function is widely used so this change could be a bit tricky

Apart from that LGTM