search

huridocs / uwazi

Uwazi is a web-based, open-source solution for building and sharing document collections
http://www.uwazi.io
MIT License
242 stars 80 forks source link

Tables migration #7131

Closed Zasa-san closed 2 months ago

Zasa-san commented 3 months ago

fixes #7052 #6431

PR checklist:

QA checklist:

Zasa-san commented 2 months ago

Great job! I did some tests having the following comments:

* The Filters page has some unexpected behaviors after doing some editions:
  - Editing an instance without filters, adding several filters, saving, deleting 1 filter, the table is emptied, the data is correct after reloading.
  - After some editions, DnD starts working wrongly, some elements can't be moved out or into a group, or moving an item into a group ends with moving other items into it or changing the order. Two times when this  happened, select all starts a loop rendering having the error "Maximum update depth exceeded"

This was a mistake in rowIds, fixed!

* Some actions column headers don't have the bottom border.

This is a problem on all these new tables, if it's simple I'll fix it in this PR, otherwise it's going to be fixed separately.

* Filters and Menu items are not translatable.

Menu items are translatable after saving. Can you confirm that? Translate them before saving would not be possible.

Filters it's a whole other problem. Groups are translatable after saving, they are part of the Filters context, but single filters are not. They are the actual template names and do not exist on the Filters context. I could make them translatable but the user would have no way of knowing that what they are translating is the NAME of the template, not the name of the filter. I will remove translate from the filter UI for items, since I don't think it's a good idea that users translate tamplate names by mistake.

* It isn't clear to me what is the solution for [Difficult to determine editing row on larger screens #6431](https://github.com/huridocs/uwazi/issues/6431)

Rows highlighted as you hover over them ;)

There are also a couple of things from previous developments that maybe can be easily fixed in this PR.

* Filters action buttons have a different order than other pages

Fixed!

* Relationship Types show the translated value followed by the original name wrapped by parenthesis, this is different in other pages like templates

That's right, removed the translate there.

aphilop commented 2 months ago

Some questions/comments to check if they should be part of this PR:

image

image

Zasa-san commented 2 months ago

Some questions/comments to check if they should be part of this PR:

  • I am wondering why in the Filters table we don't show "Selected x of y" next to the Delete button when item(s) are selected?

  • Same as above in the Uploads table. Also in this table the action buttons at the bottom are not at the left as in all other tables.

@aphilop We have a few UI inconsistencies in the settings screen that are the result of iterating over the designs as we develop each screen.

I would suggest having an issue to list these inconsistencies, and to work on it after we finish all the settings screens (I think only templates is missing now).

We have this issue here to get started: https://github.com/huridocs/uwazi/issues/6424

And then some minor issues that could be solved on a final pass on the settings UI:

https://github.com/huridocs/uwazi/issues/2032 https://github.com/huridocs/uwazi/issues/6837 https://github.com/huridocs/uwazi/issues/6757 https://github.com/huridocs/uwazi/issues/6425 https://github.com/huridocs/uwazi/issues/6435

Usually we don't find time to address these minor issues, so it could be a good thing to compile them into a big one and solve them after we have migrated all the settings screens.