search

hurlbertlab / dietdatabase

Creative Commons Zero v1.0 Universal
10 stars 9 forks source link

remove unnecessary quotes for citation/habitats to avoid propagation of quotes. #100

Closed jhpoelen closed 6 years ago

jhpoelen commented 6 years ago

hey @ahhurlbert - I noticed that citation strings (and habitats) in your dataset propagate including the double quotes. This is because your dataset is treated as a tab-separated-value format in which quoting of text fields with comma's is not needed / supported. To avoid downstream parsing confusion, I would like you to consider my pull request. If you do accept it, would might want to instruct your collaborators to turn off the quotation of text fields on saving the tsv file.

Hope this helps.

Also see, https://github.com/hurlbertlab/dietdatabase/issues/43

jhpoelen commented 6 years ago

Rather than attempting to convince @ahhurlbert to remove double quotes (see https://github.com/hurlbertlab/dietdatabase/issues/43) at the source, I've implemented some method in GloBI (see https://github.com/jhpoelen/eol-globi-data/commit/46c158025792e175dbae9dca70b76a501d938ff4) to rid the double quotes https://github.com/hurlbertlab/dietdatabase/issues/43 .