search

hurlbertlab / dietdatabase

Creative Commons Zero v1.0 Universal
10 stars 9 forks source link

suggestion regarding usage of values like "unverified" in Prey_Name_ITIS_ID column #90

Closed jhpoelen closed 6 years ago

jhpoelen commented 6 years ago

Currently, AvianDietDatabase.txt contains a column called Prey_Name_ITIS_ID. GloBI expected the column to be only used to capture ITIS ids related to prey names. However, while chasing down some naming bug related to domestic chickens, I found that the value unverified is used in the column to document that the name needs attention.

I'll make a special check in GloBI to make sure that Prey_Name_ITIS_ID contains a number to filter out values like unverified. However, I would urge you to create a separate column to capture the curation state of the prey name in order to reduce confusion among future contributors and users.

Would it be an idea to resurrect the previously used Prey_Name_Status and insert this as a column next to the Prey_Name_ITIS_ID column?

jhpoelen commented 6 years ago

related to issue https://github.com/jhpoelen/eol-globi-data/issues/327 .

ahhurlbert commented 6 years ago

Prey_Name_ITIS_ID is now numeric only, and the Prey_Name_Status field was resurrected as suggested, which takes on values of "verified" if a valid ITIS ID was found, "accepted" if no valid ITIS ID was found but someone has looked into the taxonomic entity and decided it represents a potentially valid concept that is missing from or classified differently in ITIS, and "unverified" if no valid ITIS ID was found and no one has looked into it yet.

jhpoelen commented 6 years ago

Thanks!