hurlenko / mloader

Download manga from mangaplus.shueisha.co.jp
GNU General Public License v3.0
153 stars 33 forks source link

fix cases where there are no images on the web site, error 404 #46

Closed darodi closed 1 year ago

darodi commented 1 year ago

fix cases where there are no images on the web site, error 404

for example, Terra Formars last chapter gives a 404 error on the web site:

python.exe -m mloader -l -r --chapter-subdir -t 100025

01.06.2023 12:49:16 |   INFO   |   loader.py    138  | 29/29) Manga: Terra Formars
01.06.2023 12:49:16 |   INFO   |   loader.py    139  |     Author: Ken-ichi Tachibana / Yu Sasuga
01.06.2023 12:49:17 |  ERROR   |  __main__.py   223  | Failed to download manga
Traceback (most recent call last):
  File "C:\Users\rodi_\workspace\mloader\mloader\__main__.py", line 215, in main
    loader.download(
  File "C:\Users\rodi_\workspace\mloader\mloader\loader.py", line 189, in download
    self._download(manga_list)
  File "C:\Users\rodi_\workspace\mloader\mloader\loader.py", line 144, in _download
    chapter = viewer.pages[-1].last_page.current_chapter
              ~~~~~~~~~~~~^^^^
  File "C:\Users\rodi_\workspace\mloader\venv\Lib\site-packages\google\protobuf\internal\containers.py", line 93, in __getitem__
    return self._values[key]
           ~~~~~~~~~~~~^^^^^
hurlenko commented 1 year ago

Hey @darodi, sorry for the late response. I have been pretty busy lately. From what I understood it was a temporary issue. I can't reproduce it now. I'd rather not incorporate hacks for temporary issues. If you can't reproduce it either, I suggest we close the pull request.

darodi commented 1 year ago

it was temporary issue indeed