hurlenko / orly

Download O'Reilly books as EPUB.
MIT License
61 stars 8 forks source link

Cannot download ebook #10

Closed kumiter closed 3 months ago

kumiter commented 3 months ago

Hello,

Could you please to take a look on below issue when I'm trying to download:

orly-0.1.6\src\epub\builder.rs:236:17: assertion left == right failed left: 0 right: 1 stack backtrace: 0: 0x7ff7d2ae25c8 - 1: 0x7ff7d270adf9 - 2: 0x7ff7d2ad4c91 - 3: 0x7ff7d2ae3fa6 - 4: 0x7ff7d2ae389a - 5: 0x7ff7d2ae47a7 - 6: 0x7ff7d2ae41e7 - 7: 0x7ff7d2ae412f - 8: 0x7ff7d2ae4118 - 9: 0x7ff7d2c27a14 - locale_charset 10: 0x7ff7d2c27bf3 - locale_charset 11: 0x7ff7d2c292c4 - locale_charset 12: 0x7ff7d2a02d6a - 13: 0x7ff7d26aec72 - 14: 0x7ff7d26c9377 - 15: 0x7ff7d26c0cef - 16: 0x7ff7d2653af0 - 17: 0x7ff7d26cb53b - 18: 0x7ff7d2bf6dec - locale_charset 19: 0x7ffa3f20257d - BaseThreadInitThunk 20: 0x7ffa40b4af28 - RtlUserThreadStart

image

hurlenko commented 3 months ago

What is the id of the book? I want to reproduce it

kumiter commented 3 months ago

What is the id of the book? I want to reproduce it

Hi @hurlenko ,

Book's ID 9780071663489

Thank you.

hurlenko commented 3 months ago

@kumiter Try version 0.1.7

kumiter commented 3 months ago

Hi @hurlenko ,

Many thanks for your quick response, let me try and back to you the result.

kumiter commented 3 months ago

Hi @hurlenko ,

I can download ebook without issue. But there is some font issue with special characters. Example below:

hurlenko commented 3 months ago

I don't have this problem, it might be something with your reader

kumiter commented 3 months ago

Hi @hurlenko ,

I've tried both online and offline reader and also convert to PDF with same issue. Maybe relating with my font decoder during output process.

Many thanks for your help.

hurlenko commented 3 months ago

There might be some errors because the source files of the book may contain incompatible css rules or html tags. This is something I don't really want to dig in. Many ebook readers deal with it just fine, but still, the epub files produced by orly are not always 100% correct. Even though i tried to fix all errors and make it pass the epubcheck validator, each book might contain some incompatible css or html. You can try to convert it to some other format like mobi using calibre before using. It helps sometimes