Fix SubscriptionExpired error when the subscription is still valid

hurlenko / orly

Download O'Reilly books as EPUB.

MIT License

61 stars 8 forks source link

Fix SubscriptionExpired error when the subscription is still valid #9

Closed IrvanFza closed 3 months ago

IrvanFza commented 5 months ago

This PR fixes the SubscriptionExpired error while the current subscription is still active. Turn out that when the subscription is still active, the response doesn't have a cancellation_date value. So I skip the entire expiration check if cancellation_date is empty.

Active subscription response example:

BillingInfo {
    subscription: SubscriptionInfo {
        cancellation_date: None,
    },
    trial: TrialInfo {
        trial_expiration_date: Some(
            "2019-11-17T04:02:39.550054Z",
        ),
    },
}

IrvanFza commented 5 months ago

P.S.: This is the first time I read and write code in Rust, so please share your thoughts if the code is bad.

hurlenko commented 3 months ago

Hi! I've used a bit different approach but thanks anyway! The fix has been released in version 0.1.6

theRedCount commented 3 months ago

Today I have the same problem with credentials and I didn't understand which cookie to use, I tried them all without any success.

hurlenko commented 3 months ago

@theRedCount Can you elaborate? What kind of subscription you have (corporate, personal), give some logs. What cookies you used, how you passed them as cli args?

hurlenko commented 3 months ago

How i test cookie authorization - go to the website, login, open any book, look for request cookie, copy it all, run orly

orly --cookie "$(pbpaste)" <book_id>