hurricane-response / response-theme

Jekyll theme scaffold for deploying CFA disaster response/shelter tracking map
MIT License
2 stars 8 forks source link

Fix: API Endpoint #77

Closed miklb closed 5 years ago

miklb commented 5 years ago

Description

This pull request replaces the API endpoint with the production database. It also exposes the map zoom to config file.

Addresses issue #76

List of changes

Breaking in that existing deploys will default to the zoom set in the theme config. Dorian needs to be re-centered on the map and can update zoom at same time.

Checklist:

miklb commented 5 years ago

@plocket could you take a look at this PR and let us know what you think? I know you can't approve PRs but your contributions and opinion matters.

plocket commented 5 years ago

Turns out I can approve PRs! If you prefer I can remove the approval, though, and let one of the long-standing contributors have at it.

plocket commented 5 years ago

One caveat - this does handle the zooming, but there still isn't really different types of data to test with. Maybe the title of that issue could be changed to more specifically say that it's fixing the fetch error/page not loading when trying to access the Florence endpoint.

miklb commented 5 years ago

No, it doesn’t fix types of data, but it does fix endpoint & provide live data to continue to allow as much participation as possible for now.