'Note' null and 'Pets' null (front end fix). Fixes #74 - Githubissues

hurricane-response / response-theme

Jekyll theme scaffold for deploying CFA disaster response/shelter tracking map

MIT License

2 stars 8 forks source link

'Note' null and 'Pets' null (front end fix). Fixes #74 #78

Closed plocket closed 5 years ago

plocket commented 5 years ago

Description

Fixes issue #74

Couldn't be fully tested because all shelter data had null values for pets or notes.

Fixes 'Pets' and 'Notes' shelter detail results appearing as a string saying 'null' when their value is handed in as 'null' or null.

For 'Pets', it turns 'null' into 'Unkown'.
For 'Notes', it turns 'null' into 'None'.

List of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] This pull request relates to a ticket.
[ ] This code is tested. (Could not be tested non-null shelter data)
[x] I want my code added to the response theme.

plocket commented 5 years ago

Working on a solution that will fit within these parameters. That is, this PR will not address inconsistent detail headings shown.

[That will be a UX and breaking change issue.]