search

hurrymaplelad / teact

Build React element trees by composing functions
MIT License
26 stars 6 forks source link

ie tag error #5

Open jahbini opened 8 years ago

jahbini commented 8 years ago

the ie tag is not configured properly and fails during render.

The doctype tag is also absent

jahbini commented 8 years ago

And the raw tag from teacup is also missing -- it's like the text tag, but does not escape html elements

hurrymaplelad commented 8 years ago

@jahbini thanks for the heads up! I haven't seen many folks using React to bootstrap their whole page, meta tags and all, so I didn't prioritize ie and doctype tags, but I'd happily merge a PR for 'em.

The raw tag is a little trickier as React does its own escaping. You can use React's dangerouslySetInnerHTML today. A raw tag would likely need to make assumptions about what type of tag (div or span for example) to wrap the raw content with. Not opposed, just haven't needed it yet.

jahbini commented 6 years ago

I wanted to use React, but can't stand the bloat, so I adapted Teact to mithril and added back the original rendering scheme.

It now has ie, doctype and render, renderable and tag, too. And renders into three different DOM schemes: React or Mithril virtual DOM and HTML text. Server or client side. Check out http://github.com/jahbini/halvalla