huseinzol05 / Stock-Prediction-Models

Gathers machine learning and deep learning models for Stock forecasting including trading bots and simulations
Apache License 2.0
7.66k stars 2.74k forks source link

Deep learning examples df_test not used #106

Open martindevora opened 3 years ago

martindevora commented 3 years ago

Hello,

Just a newcomer to the ML world and have been trying some simple algorithms. I wanted to step further and reached your great examples under the deep_learning section. After having a look at several of the algorithms I've just realized that df_test is not used in the forecast method or anywhere else as stated at the beginning of some of the notebooks (like the Attention is all you need one). Am I missing anything or should df_train be replaced by df_test at some point? Sorry if you find my question very stupid.

Kind regards and thanks for your great contribution.