huserben / TfsExtensions

Extensions for TFS 2015+ such as custom Widgets (require TFS 2017) and Build Tasks
MIT License
45 stars 22 forks source link

Using build definition ID rather than name #126

Closed arazabishov closed 4 years ago

arazabishov commented 4 years ago

First of all, thanks a lot for putting in work to maintain the extension!

The docs specify that build definition name should be used for triggering the builds. Is there a possibility to use build definition ID, which is less prone to changes?

Thanks!

huserben commented 4 years ago

Hi @ArazAbishov

Thanks for the input. Yes it's possible, I would suggest the following behavior:

The advantage is that we will not break compatibility and we also don't need to add new configuration options but we can just reuse the existing field :-)

I implemented a version that seems to work fine: grafik

I need to do some additional testing but somewhen tomorrow I'll be pushing a new version that should include the change

huserben commented 4 years ago

@ArazAbishov

I published now a new version that contains the change. Please let me know whether it works as expected.

arazabishov commented 4 years ago

Thanks for dedicating time to add the feature @huserben, and sorry for the late response. I will test the new version and will come back to you.

arazabishov commented 4 years ago

Ah, my apologies, I forgot to respond with the feedback. The updated version of the task works really well. Thank you!