search

huserben / TfsExtensions

Extensions for TFS 2015+ such as custom Widgets (require TFS 2017) and Build Tasks
MIT License
44 stars 22 forks source link

Download Artifacts not working at MAC Build Machines #130

Closed jensheidrich-acn closed 4 years ago

jensheidrich-acn commented 4 years ago

When using the "Download Build Artifacts" feature at a build running on a MAC build machine, there is an issue with / and .

It seems to add automatically a \ before the zip name, which is a problem on MacOS systems.

Potentially this is the root cause (huserben/TfsRestService): https://github.com/huserben/TfsRestService/blob/a801b4cd0f32c6d2d970d53d122ffaf5bf9cd873/index.js#L201 if (!downloadDirectory.endsWith("\\")) { downloadDirectory += "\\";

Drop Directory: "$(Build.ArtifactStagingDirectory)/1/" Result: Folder not created; Nothing downloaded Log extract: 2020-03-19T16:23:06.0945590Z All builds are finished 2020-03-19T16:23:06.0946450Z Downloading build artifacts to /Volumes/HDD2/Builds/A1/77/a/1/ 2020-03-19T16:23:06.0952990Z Downloading artifacts for Build 844852 2020-03-19T16:23:06.0958850Z Directory /Volumes/HDD2/Builds/A1/77/a/1/ does not exist - will be created 2020-03-19T16:23:06.1232910Z Found 1 artifact(s) 2020-03-19T16:23:06.1233170Z Downloading artifact IPA... 2020-03-19T16:23:07.0972950Z Stored artifact here: /Volumes/HDD2/Builds/A1/77/a/1/\IPA.zip

Drop Directory: "$(Build.ArtifactStagingDirectory)/1" Result: Folder not created; Nothing downloaded Log extract: 2020-03-19T16:58:35.9418530Z All builds are finished 2020-03-19T16:58:35.9418920Z Downloading build artifacts to /Volumes/HDD2/Builds/A1/77/a/1 2020-03-19T16:58:35.9426400Z Downloading artifacts for Build 844868 2020-03-19T16:58:35.9431030Z Directory /Volumes/HDD2/Builds/A1/77/a/1 does not exist - will be created 2020-03-19T16:58:35.9693920Z Found 1 artifact(s) 2020-03-19T16:58:35.9694270Z Downloading artifact IPA... 2020-03-19T16:58:36.9596560Z Stored artifact here: /Volumes/HDD2/Builds/A1/77/a/1\IPA.zip

Environment Info: Team Foundation Server 2018 Update 3.2 MacOS 10.14.6

huserben commented 4 years ago

Hi @jensheidrich-acn

thanks for reporting this. Yes that's cleary an issue and I haven't thought about it.

I will fix this as soon as possible, however I can currently not give any statements on when I will find the time to do so. I hope I can have a look at it over the upcoming weekend.

I'll let you know here once I have an update.

huserben commented 4 years ago

@jensheidrich-acn

I have published now a new version of the tasks that should deal better with different separators used on the different operating systems.

Could you verify whether it solves your problem now and let me know in any case?

jensheidrich-acn commented 4 years ago

Awesome response time! After your fix it works perfectly:

Logs:

All builds are finished
Downloading build artifacts to /Volumes/HDD2/Builds/A1/77/a/Enterprise/
Downloading artifacts for Build 845355
Directory /Volumes/HDD2/Builds/A1/77/a/Enterprise/ does not exist - will be created
Found 1 artifact(s)
Downloading artifact IPA...
Stored artifact here: /Volumes/HDD2/Builds/A1/77/a/Enterprise/IPA.zip

image

huserben commented 4 years ago

Hi @jensheidrich-acn

Nice to hear. Thanks again for reporting this and helping to improve the task.

Please don't hesitate to create new issues in case you run into a problem, you have a feature request or a just a question.