huserben / TfsExtensions

Extensions for TFS 2015+ such as custom Widgets (require TFS 2017) and Build Tasks
MIT License
44 stars 22 forks source link

Node6 execution handler deprecation warning #196

Closed FKSI closed 2 years ago

FKSI commented 2 years ago

Hi,

Any plan to migrate to Node10 handler?

2021-11-22T15:50:41.5080068Z ##[section]Starting: TriggerBuild
2021-11-22T15:50:41.5089985Z ==============================================================================
2021-11-22T15:50:41.5090529Z Task         : Trigger Build
2021-11-22T15:50:41.5091081Z Description  : This tasks allows to trigger a new Build (add it to the queue) as part
of a Build Definition. It contains as well some conditions that can be applied, for example if the last build of
certain definition was successful or not.
2021-11-22T15:50:41.5091602Z Version      : 3.2.2
2021-11-22T15:50:41.5091850Z Author       : Benjamin Huser
2021-11-22T15:50:41.5092105Z Help         : 
2021-11-22T15:50:41.5092384Z ==============================================================================
2021-11-22T15:50:41.5174344Z ##[warning]This task uses Node 6 execution handler, which will be deprecated soon.
If you are the developer of the task 
- please consider the migration guideline to Node 10 handler 
- ***://aka.ms/migrateTaskNode10. 
f you are the user - feel free to reach out to the owners of this task to proceed on migration.
huserben commented 2 years ago

Hi @FKSI

Thanks for making me aware of this, it was not on my radar as of now. Currently I don't have too much time on my hands that I can spend, but I'll keep the issue open and try to look into it as soon as I can.

richhoward1 commented 2 years ago

Hey, just wanted to add some information - they've added a date for the removal of the node 6 hander - March 31st 2022.

==============================================================================
2021-12-17T08:38:21.2292584Z Task         : Trigger Build
2021-12-17T08:38:21.2293160Z Description  : This tasks allows to trigger a new Build (add it to the queue) as part of a Build Definition. It contains as well some conditions that can be applied, for example if the last build of certain definition was successful or not.
2021-12-17T08:38:21.2293548Z Version      : 3.2.2
2021-12-17T08:38:21.2293891Z Author       : Benjamin Huser
2021-12-17T08:38:21.2294271Z Help         : 
2021-12-17T08:38:21.2294475Z ==============================================================================
2021-12-17T08:38:21.2633081Z ##[warning]This task uses Node 6 execution handler, which will be removed March 31st 2022. If you are the developer of the task - please consider the migration guideline to Node 10 handler - https://aka.ms/migrateTaskNode10 (check this page also if you would like to disable Node 6 deprecation warnings). If you are the user - feel free to reach out to the owners of this task to proceed on migration.
huserben commented 2 years ago

Thanks @richhoward1 for letting me know.

I have some plans on checking this out in the coming weeks :-) I'll keep you updated about the progress in this issue.

huserben commented 2 years ago

Hi @richhoward1 and @FKSI

Turns out "in the coming weeks" means early on the next saturday - I just uploaded a new version of the extension that contains updated tasks. I increased the minor version of all the tasks and they should now use the Node10 Execution handler:

They should automatically get installed on your Azure DevOps instance.

Could you please check whether the warning for you now also disappears and in general give me feedback if everything still works as before. As I had to update quite some packages there is always the chance of something broken due to a dependency. I did do smoke tests on my systems, but of course it's always possible that I missed something.

Thanks for your help.

richhoward1 commented 2 years ago

Hi @Huserben,

Firstly, thanks for your quick action.

I've confirmed our DevOps instance now doesn't have the warning, and appears to work as expected for our use cases.

Thanks!

huserben commented 2 years ago

Hi @richhoward1 @FKSI

So it seems like some people with (older) versions of Azure DevOps Server started having issues with the node10 execution handler after the update. As apparently you can't pin the minor version, I had to revert the changes in the tasks and instead continue with a new major version of each task.

What this means is that unfortunately you will need to adjust your pipeline and increase the major version of each task used. This will not happen automatically.

For more details please see this description.

Sorry for the inconvenience but it was the only reasonable solution I saw to enable the tasks again for the other people that had issues.

richhoward1 commented 2 years ago

Hi again @huserben - just wanted to say thanks for the update. We've updated to Trigger Build v4.x and everything is looking good for our use cases.

Thanks again for your efforts - I hope you get to relax for the holidays!

FKSI commented 2 years ago

I confirm as well the upgrade was automatically done! 1000000x thanks :)!

huserben commented 2 years ago

@FKSI @richhoward1 Awesome!

Thanks for bringing this issue my attention. If you in future have any questions, problems or proposals for features do not hesitate to raise a new issue so it can be taken up.