search

huserben / TfsExtensions

Extensions for TFS 2015+ such as custom Widgets (require TFS 2017) and Build Tasks
MIT License
45 stars 22 forks source link

Wait for build task fail on artifacts download if it waits for two triggered builds #48

Closed atlesp closed 6 years ago

atlesp commented 6 years ago

It fails when it tries to download artifacts for the build that finish last with

[error]Invalid URI "build/builds/254/artifacts"

Example of the log: 2018-02-13T11:38:24.5414637Z Downloading build artifacts to D:\a/SubBuilds 2018-02-13T11:38:24.5423445Z Downloading artifacts for 277 2018-02-13T11:38:24.5427858Z Directory D:\a/SubBuilds does not exist - will be created 2018-02-13T11:38:24.6433886Z Found 2 artifact(s) 2018-02-13T11:38:24.6434990Z Downloading artifact CloudStackAzuredeploy... 2018-02-13T11:38:24.6509015Z Stored artifact here: D:\a/SubBuilds\CloudStackAzuredeploy.zip 2018-02-13T11:38:24.6510156Z Downloading artifact AzureDeploy... 2018-02-13T11:38:24.6524515Z Stored artifact here: D:\a/SubBuilds\AzureDeploy.zip 2018-02-13T11:38:24.6525544Z Downloading artifacts for 278 2018-02-13T11:38:24.6657736Z ##[error]Invalid URI "build/builds/278/artifacts" 2018-02-13T11:38:24.8804141Z ##[section]Finishing: Waiting for other builds to finish

I made a simple test build that to verify it, and it also worked on one triggered build, but not two.

huserben commented 6 years ago

Hi @atlesp

hmm I will try to reproduce this issue locally and will let you know once I figured something out.

huserben commented 6 years ago

I found the problem and was able to fix it. Please with the latest version of the Task (2.5.4 for TriggerBuild and 1.2.5 for WaitForBuild).

Please let me know if it works now for you.

Thanks for your feedback!

atlesp commented 6 years ago

Hi @huserben It worked perfect! Thanks!

huserben commented 6 years ago

Ok, glad I could help.

Thanks again for raising the issue and please do so again if you find something else that is not working as it's supposed to or if you have any suggestions for improving the task.