fix: sourceBranch must be a string

huserben / TfsExtensions

Extensions for TFS 2015+ such as custom Widgets (require TFS 2017) and Build Tasks

MIT License

45 stars 22 forks source link

fix: sourceBranch must be a string #5

Closed nobitagamer closed 7 years ago

nobitagamer commented 7 years ago

Sorry for the last PR, it cause build fail because sourceBranch JSON require quote for string value.

huserben commented 7 years ago

Hi @nobitagamer does this fix as well the Issue you reported yesterday (https://github.com/huserben/TfsExtensions/issues/4) or was this something else?

huserben commented 7 years ago

FYI: I checked in a new version (https://github.com/huserben/TfsExtensions/commit/14f331ecc6233a758dfb310bebe78208e1e0ac49) and added double-quotes instead. I had some issues as the powershell script was throwing an exception when parsing the response when it tried to output it at the very end (exception was caused from the Convert-FromJson) so I removed it, this should fix the problems. At least my test builds now run again successfully.