search

huseyinbabal / microservices

Go gRPC Microservices
56 stars 18 forks source link

Missing Save method #2

Open patricksegantine opened 2 years ago

patricksegantine commented 2 years ago

https://github.com/huseyinbabal/microservices/blob/220857c10543a57b6176bb255cfb94826f80dc22/order/internal/adapters/db/db.go#L50

please review the topic 4.2.5 Implementing Adapters at the following point:

"You can see Get and Save methods in the code snippets below. It is important to understand how the Adapter instance is delegated to functions via receiver functions."

missing Save method on ebook.

huseyinbabal commented 2 years ago

https://github.com/huseyinbabal/microservices/blob/220857c10543a57b6176bb255cfb94826f80dc22/order/internal/adapters/db/db.go#L50

please review the topic 4.2.5 Implementing Adapters at the following point:

"You can see Get and Save methods in the code snippets below. It is important to understand how the Adapter instance is delegated to functions via receiver functions."

missing Save method on ebook.

Thanks for your valuable contributions, will address them asap, but keep in mind that, they cannot be reflected to ebook directly, it will be rereviewed and gradually published there. Thanks in advance for your patience 🙏

patricksegantine commented 2 years ago

thanks for reply Huseyn, I added some issues on the proto repo as well, please take a look at https://github.com/huseyinbabal/microservices-proto/issues/1