husio / python-sqlite3-backup

Sqlite3 online API CPython implementation module
http://pypi.python.org/pypi/sqlitebck/
42 stars 9 forks source link

bdist_rpm fails because .h isn't included #4

Closed rjcoelho closed 9 years ago

rjcoelho commented 11 years ago

Add MANIFEST.in with recursive-include src/_sqlite *.h

husio commented 11 years ago

Isn't that because the the python package is splited into runtime and dev? I think that for example on ubuntu, python-dev package is required to build this module.

I don't want to include more than required.

rjcoelho commented 11 years ago

Currently "python setup.py bdist_rpm" fails. The simplest solution i have found is to include .h in MANIFEST.in since Extension only supports .c files. But i'm no export on distutils.

husio commented 11 years ago

I'm not sure it that's the right way to do, but I also don't have any rpm system that I could use to test it. I need a proper explanation why I should do what you're suggesting, before changing anything.

rjcoelho commented 11 years ago

Basically sdist fails to include .h files. Try it and compare tarball generated with one fetched from pypi. And then bdist fails to build. One solution is to include then in data_files or MANIFEST.in. I also See http://bugs.python.org/issue1083299 and https://groups.google.com/forum/?fromgroups=#!topic/comp.lang.python/ZO1ZVExMBH4