Open ntinti opened 5 years ago
which bugs are worth to be mentioned?
Played with the mouse and select a few cells to make a sum and it freezes. The table document is corrupt an I can not open it again.
Just tried, couldn't reproduce it.
Played with the mouse and select a few cells to make a sum and it freezes. The table document is corrupt an I can not open it again.
6.2-6 is not possible to build, because tag cp-6.2-6
does not depend on any existing branch and the check script forces to find a tag inside a branch.
See https://github.com/LibreOffice/core/releases/tag/cp-6.2-6
Why is it forced to find a valid commit hash inside a branch? Whats the point of https://github.com/husisusi/officeonlin-install.sh/blob/master/lib/SearchInGit.sh#L78?
If the pointer was removed from the git repository then it's nothing you can do.
The feature works fine.
I removed this "feature" to force a checkout of a commit id and tag (https://github.com/rkorn86/officeonlin-install.sh/tree/patch-searchInGit) and built successfully a 6.2-6:
cfg:
set_online_regex='distro/collabora/co-4-2-0$'
lo_src_tag='cp-6.2-6'
lo_dir="/opt/libreoffice"
lo_non_free_ttf=true
poco_version=1.9.4
lool_src_tag='CODE-4.2.0-6'
lool_dir="/opt/lool"
lool_configure_opts='--disable-werror --with-lokit-path=/opt/libreoffice/include'
Result:
About
LOOLWSD
4.2.0 (git hash: 48938d4a)
LOKit
Collabora OfficeDev 6.2-6 (git hash: 7c4bddd)
If the pointer was removed from the git repository then it's nothing you can do.
The feature works fine.
The "pointer" aka "tag" is not removed. The pointer still shows to a valid git commit. However the git commit has a detached head. Thats why no "named" branch exists and the check fails.
Nice! Any perceived improvements?
Result:
About LOOLWSD 4.2.0 (git hash: 48938d4a) LOKit Collabora OfficeDev 6.2-6 (git hash: 7c4bddd)
Nice! Any perceived improvements?
Result:
About LOOLWSD 4.2.0 (git hash: 48938d4a) LOKit Collabora OfficeDev 6.2-6 (git hash: 7c4bddd)
I don't see any in comparison to 6.2-5, but I'm not the end user of it. The other ~450 nextcloud users are using it at work :)
I found a bug on Lool 4.2 and O6.2-5. I can not past some text on search field: Any idea?
I tried loolwsd 4.2.1, but I have the same issue. I can not past text on search field: Does anyone have this issue?
yes, same here.
Does anyone have this issue?
which branch? which lool_src_tag?
Yes same here. Content for search field is pasted in the calculation row ....
About
LOOLWSD
4.2.1 (git hash: 8228a565)
LOKit
Collabora OfficeDev 6.2-8 (git hash: 5ebb43f)
CFG
set_online_regex='distro/collabora/co-4-2-0$'
lo_src_tag='cp-6.2-8'
lo_dir="/opt/libreoffice"
lo_non_free_ttf=true
poco_version=1.9.4
lool_src_tag='CODE-4.2.1-2'
lool_dir="/opt/lool"
lool_configure_opts='--disable-werror --with-lokit-path=/opt/libreoffice/include'
With patched installer https://github.com/rkorn86/officeonlin-install.sh/tree/patch-searchInGit and german language via perl -pi -e "s/with-lang=/with-lang=de/" lib/default.cfg
Bug on right sidebar with cutted tooltips and colorpickers still exists. Bug on search field pasting still exists.
set_name=code
lo_src_branch='distro/collabora/cp-6.2'
lo_src_tag='cp-6.2-5'
set_online_regex='collabora/code-4.2'
lool_src_branch='distro/collabora/code-4.2.0-4'
lool_src_tag='CODE-4.2.0-4'
lool_configure_opts='--with-lokit-path=/opt/libreoffice/include'
lool_configure_opts='--with-lokit-path=/opt/libreoffice/include --disable-werror'
bug on search field pasting exists in write&calc.
Well at least i found a working config now, it seems:
allowed_domains="nextcloud.mydomain.de"
set_online_regex='collabora/code-4.2'
lo_src_branch='distro/collabora/cp-6.2'
lo_src_tag='cp-6.2-5'
lo_dir="/opt/libreoffice"
poco_forcebuild=true
lool_src_branch='distro/collabora/code-4.2.1-4'
lool_src_tag='CODE-4.2.1-4'
lool_dir="/opt/lool"
lool_configure_opts='--disable-werror --with-lokit-path=/opt/libreoffice/include'
lool_forcebuild=true
But somehow i can´t rebuild LOOL anymore. It worked yesterday fine. I tried to rebuild now, because it build before with the config above on version 4.1.0, eventhough i selected 4.2.1-4.
Is this known somehow?
lool:x:106:112::/opt/lool:/usr/sbin/nologin
From https://github.com/LibreOffice/core.git
Error: current directory is not a git repository !
Paketlisten werden gelesen...
Abhängigkeitsbaum wird aufgebaut....
Statusinformationen werden eingelesen....
node-gyp ist schon die neueste Version (3.8.0-6).
npm ist schon die neueste Version (5.8.0+ds6-4).
libssl-dev ist schon die neueste Version (1.1.1d-0+deb10u2).
libpococrypto60 ist schon die neueste Version (1.9.0-5+b1).
0 aktualisiert, 0 neu installiert, 0 zu entfernen und 0 nicht aktualisiert.
sudo: ./autogen.sh: Befehl nicht gefunden
bash: ./configure: Datei oder Verzeichnis nicht gefunden
Edit: Well at least im not able to rebuild LOOL at the moment. Would be nice if someone could test it and report the result. It doesn´t matter which version combinations i use, it fails the whole time.
@Alternativend Happy to see you succeeded.
Error: current directory is not a git repository !
I think there is a problem with the path of your libre office repo (the one in /opt/libreoffice/) or with the git repo there.
Check it and maybe delete it for the script to redo à git clone.
Or you can also try with the option "lo_forcebuild=true" to see what happens.
If it's not that, try tu put some echos in the script to try to find what command returns that error.
@quenenni I got it. I´ve just reinstalled the whole machine, it was faster for me because he ran into different errors after cleaning up /opt/libreoffice.
It´s basically working now!!
Here is my actual config i used:
allowed_domains="nextcloud.mydomain.de"
set_online_regex='collabora/code-4.2'
lo_src_branch='distro/collabora/cp-6.2'
lo_src_tag='cp-6.2-5'
lo_dir="/opt/libreoffice"
poco_forcebuild=true
lool_src_branch='distro/collabora/code-4.2.1-4'
lool_src_tag='CODE-4.2.1-4'
lool_dir="/opt/lool"
lool_configure_opts='--disable-werror --with-lokit-path=/opt/libreoffice/include'
lool_forcebuild=true
Thanks a lot for your help!
Has anyone been able to successfully compile LOOL on Raspberry Pi 4 aarch64?
allowed_domains="your.domain" lool_configure_opts='--disable-werror' set_core_regex='cp-6.2' set_online_regex='collabora/co-4.2.3' lo_src_tag='cp-6.2-11' lo_src_branch='distro/collabora/cp-6.2' lool_src_branch='distro/collabora/co-4-2-3' lool_src_tag='CODE-4.2.3-1' lool_forcebuild=true
you need to delete disable-gstreamer-0-10 and disable-kde4 from ../lib/default.cfg
after first build you will get "configure: error: header LibreOfficeKit/LibreOfficeKit.h not found, perhaps you want to use --with-lokit-path" lool_configure_opts='--with-lokit-path=/opt/libreoffice/include' is not working... you need to copy /opt/libreoffice/include to /opt/online/bundled and run the script again
apt install hunspell-en (hunspell-'whatever you need') for spell checking
I was able to compile it without errors, but only one thing does not work, which is when you create a new document, I get the image error and in the loolwsd.log log I get this with all versions of lool 4.2 it gives me the same problem. Once the error appears, I close the libreoffice online application, and the new file was created successfully and I can open, edit and save it without problems surely I'm forgetting something, does anyone know where this error can come from?
log:
kit-04400-03303 2020-05-20 12:06:25.996104 [ kit_009 ] ERR Failed to load: file:///user/docs/RCkYcnkwy0Ct4OIo/New%20Document.odt, error: Unsupported URL https://t-nube.rosario.gob.ar/index.php/apps/richdocuments/wopi/template/895996?access_token=vSRxqTvQqPjEPWmVaEZISouycWzXDV1c: "type detection failed"| kit/Kit.cpp:1725 kit-04400-03303 2020-05-20 12:06:25.996153 [ kit_009 ] ERR Failed to get LoKitDocument instance for [file:///user/docs/RCkYcnkwy0Ct4OIo/New%20Document.odt].| kit/ChildSession.cpp:627 kit-04400-03303 2020-05-20 12:06:25.996181 [ kit_009 ] ERR error: cmd=load kind=faileddocloading| ./common/Session.hpp:125 kit-04400-03303 2020-05-20 12:06:25.996240 [ kit_009 ] WRN Document::ViewCallback. Session [-1] is no longer active to process [LOK_CALLBACK_ERROR] [{
I was able to compile it without errors, but only one thing does not work, which is when you create a new document, I get the image error and in the loolwsd.log log I get this with all versions of lool 4.2 it gives me the same problem.
yes ... same thing....
Hi, i just build it with the following options:
allowed_domains="mydomain"
set_core_regex='cp-6.2'
set_online_regex='collabora/co-4.2.3'
lo_src_branch='distro/collabora/cp-6.2'
lo_src_tag='cp-6.2-11'
lo_dir="/opt/libreoffice"
lo_forcebuild=true #force compilation
lo_non_free_ttf=true # add Microsoft fonts to Ubuntu
poco_version=1.9.4 #$poco_version_latest #latest releases available
poco_forcebuild=true
lool_src_branch='distro/collabora/co-4-2-3'
lool_src_tag='CODE-4.2.3-1'
lool_dir="/opt/lool"
lool_configure_opts='--disable-werror --with-lokit-path=/opt/libreoffice/include --with-lang=de'
lool_forcebuild=true
you need to delete disable-gstreamer-0-10 and disable-kde4 from ../lib/default.cfg
I did this.
after first build you will get "configure: error: header LibreOfficeKit/LibreOfficeKit.h not found, perhaps you want to use --with-lokit-path" lool_configure_opts='--with-lokit-path=/opt/libreoffice/include' is not working... you need to copy /opt/libreoffice/include to /opt/online/bundled and run the script again
That did not happen for me.
apt install hunspell-en (hunspell-'whatever you need') for spell checking
I did this too, but the default language is still not correct for me and spell checking isn´t working either.
Edit: At least "i" found out how to change the default language for new documents, which is great:
https://help.nextcloud.com/t/where-are-the-language-settings-for-collabora/3114/19
The last annoying thing i couldn´t solve so far is that the sidebar has the wrong language. Does anyone here can tell me how to change that?
@Alternativend Thanks for sharing. I can confirm it works with those options (on debian buster).
Same problem with the sidebar that stays in english (and shouldn't)
Also, from the previous version I had, now we can work simultanously in calc files. That's an amazing improvement.
i got it working with 4.2.* …/nextcloud/apps/richdocuments/lib/Controller/WopiController.php need to comment this code (lines 213-218. app ver 3.7.0)
//** if ($wopi->hasTemplateId()) {
$templateUrl = ‘index.php/apps/richdocuments/wopi/template/’ . $wopi->getTemplateId() . ?access_token=’ . $wopi->getToken();
$templateUrl = $this->urlGenerator->getAbsoluteURL($templateUrl);
$response[‘TemplateSource’] = $templateUrl;
}*/
i got it working with 4.2.* …/nextcloud/apps/richdocuments/lib/Controller/WopiController.php need to comment this code (lines 213-218. app ver 3.7.0)
//** if ($wopi->hasTemplateId()) { $templateUrl = ‘index.php/apps/richdocuments/wopi/template/’ . $wopi->getTemplateId() . ?access_token=’ . $wopi->getToken(); $templateUrl = $this->urlGenerator->getAbsoluteURL($templateUrl); $response[‘TemplateSource’] = $templateUrl; }*/
Thanks!!! it works with your edition!!!
i'm using:
lo_src_branch='distro/collabora/cp-6.2' lo_src_tag='cp-6.2-11' lool_src_branch='distro/collabora/co-4-2-3' lool_src_tag='cp-4.2.3-1' lool_configure_opts='--with-lokit-path=/opt/libreoffice/include --disable-werror'
with this lool release, compile it without errors, but i tested with cp-4.2.3-2 and cp-4.2.3-3, with this errors: someone can help me with this errors?
kit/ChildSession.cpp: In member function ‘bool ChildSession::formFieldEvent(const char*, int, const StringVector&)’:
kit/ChildSession.cpp:1446:25: error: ‘using element_type = class lok::Document’ {aka ‘class lok::Document’} has no member named ‘sendFormFieldEvent’; did you mean ‘sendDialogEvent’?
getLOKitDocument()->sendFormFieldEvent(sArguments.c_str());
^~~~~~~~~~~~~~~~~~
sendDialogEvent
kit/ChildSession.cpp: In member function ‘bool ChildSession::completeFunction(const char*, int, const StringVector&)’:
kit/ChildSession.cpp:1465:60: error: invalid conversion from ‘const char*’ to ‘int’ [-fpermissive]
getLOKitDocument()->completeFunction(functionName.c_str());
~~~~~~~~~~~~~~~~~~^~
In file included from kit/ChildSession.hpp:17,
from kit/ChildSession.cpp:12:
/opt/libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:765:31: note: initializing argument 1 of ‘void lok::Document::completeFunction(int)’
void completeFunction(int nIndex)
~~~~^~~~~~
kit/ChildSession.cpp: In member function ‘void ChildSession::loKitCallback(int, const string&)’:
kit/ChildSession.cpp:2593:10: error: ‘LOK_CALLBACK_FORM_FIELD_BUTTON’ was not declared in this scope
case LOK_CALLBACK_FORM_FIELD_BUTTON:
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kit/ChildSession.cpp:2593:10: note: suggested alternative: ‘LOK_CALLBACK_CELL_VIEW_CURSOR’
case LOK_CALLBACK_FORM_FIELD_BUTTON:
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LOK_CALLBACK_CELL_VIEW_CURSOR
CXX kit/loolwsd_fuzzer-ForKit.o
make[2]: *** [Makefile:2978: kit/loolwsd_fuzzer-ChildSession.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/opt/online'
make[1]: *** [Makefile:3407: all-recursive] Error 1
make[1]: Leaving directory '/opt/online'
make: *** [Makefile:1174: all] Error 2
make: Leaving directory '/opt/online'
try this
set_core_regex='cp-6.2'
set_online_regex='co-4.2.4'
lo_src_repo='https://github.com/LibreOffice/core.git'
lo_src_branch='master'
lo_src_commit=''
lo_src_tag=''
lo_dir="/opt/libreoffice"
lo_forcebuild=true
lo_non_free_ttf=true
poco_version=$poco_version_latest #latest releases available
poco_forcebuild=true
lool_src_repo="https://github.com/LibreOffice/online.git"
lool_src_branch='master'
lool_src_tag='cp-4.2.4-2'
lool_dir="/opt/lool"
lool_configure_opts="--disable-werror --with-lokit-path=${lo_dir}/include"
lool_logfile='/var/log/loolwsd.log'
lool_prefix='/usr'
lool_sysconfdir='/etc'
lool_localstatedir='/var'
lool_forcebuild=true
lool_maxcon=200
lool_maxdoc=100
loolwsd_service_name='loolwsd'
try this
set_core_regex='cp-6.2' set_online_regex='co-4.2.4' lo_src_branch='master' lo_src_commit='' lo_src_tag='' lool_src_branch='master' lool_src_tag='cp-4.2.4-2' lool_configure_opts="--disable-werror --with-lokit-path=${lo_dir}/include"
Yes! with this settings works like charm Thanks!
for me, not completely. In this version, it is not possible to create new documents from templates.
The message showing up, is:
ERR Failed to load: file:///user/docs/p33a0yD6AClS3smh/och%20nee.odt, error: Unsupported URL <https://nctest.faudin.de/index.php/apps/richdocuments/wopi/template/266543?access_token=...>: "type detection failed"| kit/Kit.cpp:172
@DmDS
You wrote: you need to delete disable-gstreamer-0-10 and disable-kde4 from ../lib/default.cfg
For what reason? I have compiled it on Ubuntu 18.04 with and without the change in ../lib/default.cfg
and both worked for me (I 'don't see a difference).
Did this fix an compilation error on Debian for you or is there a functional problem after compiling if this options where not removed?
Did this fix an compilation error on Debian Exactly, fix compilation in debian buster only
Perfect thx for the answer
If someone want to compile it on Ubuntu 18.04 this is what worked for me:
apt-get install python3-polib python3-lxml
officeonline-install.cfg:
allowed_domains="... ... ..."
set_core_regex='cp-6.2'
set_online_regex='collabora/co-4.2.3'
lo_src_branch='distro/collabora/cp-6.2'
lo_src_tag='cp-6.2-11'
lo_dir="/opt/libreoffice"
lo_forcebuild=true #force compilation
lo_non_free_ttf=true # add Microsoft fonts to Ubuntu
poco_version=1.9.4 #$poco_version_latest #latest releases available
poco_forcebuild=true
lool_src_branch='distro/collabora/co-4-2-3'
lool_src_tag='CODE-4.2.3-1'
# don't change the "lool_dir" after you have compiled it once -> else you have files pointing to the wrong location
#lool_dir="/opt/lool"
lool_configure_opts='--disable-werror --with-lokit-path=/opt/libreoffice/include --with-lang=de'
lool_forcebuild=true
lo_src_tag='cp-6.2-11' lool_src_branch='distro/collabora/co-4-2-3' using the most recent richdocuments, still the creation of documents from templates fails.
lo_src_tag='cp-6.2-11' lool_src_branch='distro/collabora/co-4-2-3' using the most recent richdocuments, still the creation of documents from templates fails.
That's a pity, I think I will hold back until it starts working again. Has anybody managed to get document creation from template working with these latest builds?
Did someone test if "document creation from template" with the APP "Collabora Online in Nextcloud Hub" works? https://nextcloud.com/blog/how-to-install-collabora-online-in-nextcloud-hub/
Did someone test if "document creation from template" with the APP "Collabora Online in Nextcloud Hub" works? https://nextcloud.com/blog/how-to-install-collabora-online-in-nextcloud-hub/
It work
Did someone test if "document creation from template" with the APP "Collabora Online in Nextcloud Hub" works? https://nextcloud.com/blog/how-to-install-collabora-online-in-nextcloud-hub/
It work
Can you please let me know the steps how you was able to create and use the template?
Did someone test if "document creation from template" with the APP "Collabora Online in Nextcloud Hub" works? https://nextcloud.com/blog/how-to-install-collabora-online-in-nextcloud-hub/
It work
NO, It does not!
the best way to create new docs from templates is to use LOOLWSD 4.0.4 (git hash: a2132266) LibreOffice 6.3.4.2 (git hash: 60da17e) of all combinations I've tested the last months, this has been the one with the least issues.
the best way to create new docs from templates is to use LOOLWSD 4.0.4 (git hash: a2132266) LibreOffice 6.3.4.2 (git hash: 60da17e) of all combinations I've tested the last months, this has been the one with the least issues.
You can use the new version, the issue is the app and not lool!
…/nextcloud/apps/richdocuments/lib/Controller/WopiController.php need to comment this code (lines 213-218. app ver 3.7.0)
//* if ($wopi->hasTemplateId()) { $templateUrl = ‘index.php/apps/richdocuments/wopi/template/’ . $wopi->getTemplateId() . ?access_token=’ . >$wopi->getToken(); $templateUrl = $this->urlGenerator->getAbsoluteURL($templateUrl); $response[‘TemplateSource’] = $templateUrl; }/
This one is good: LOOLWSD 4.2.4 (git hash: 0a581c0e) Collabora OfficeDev 6.2-14 (git hash: 1120630)
Collabora OfficeDev > 6.2-14 has "Background color" issue!!
//* if ($wopi->hasTemplateId()) { $templateUrl = ‘index.php/apps/richdocuments/wopi/template/’ . $wopi->getTemplateId() . ?access_token=’ . >$wopi->getToken(); $templateUrl = $this->urlGenerator->getAbsoluteURL($templateUrl); $response[‘TemplateSource’] = $templateUrl; }/ commenting out these lines prevents templates to be used (as of my tests).
just saw this: https://git.libreoffice.org/core/+/459134ea842ad8238ab3c4efffef26843a3853c9 / does this ring a bell?
Originally posted by @joergmschulz in https://github.com/nextcloud/richdocuments/issues/1014#issuecomment-651907739 but 6.2-18 / 4.2.5 don't work better, so that's not related.
It doesn't seem to be an issue of the lool/loolwsd code. All works fine when I use the official CODE image. Using the same code, it doesn't work when selfcompiled with this script. So where could we look?
set_name=code lo_src_branch='distro/collabora/cp-6.2' lo_src_tag='co-6.2-21'
lool_src_branch='distro/collabora/co-4-2-6' lool_src_tag='cp-4.2.6-2'
lool_configure_opts='--with-lokit-path=/opt/libreoffice/include --disable-werror'
This one is good: LOOLWSD 4.2.4 (git hash: 0a581c0e) Collabora OfficeDev 6.2-14 (git hash: 1120630)
Collabora OfficeDev > 6.2-14 has "Background color" issue!!
Thanks for the info. Do you still have the style panel opened by default on the right?
sure, the style panel opens still. But, templates don't work either.
Anyone around giving a try on CODE 6.4? And if so, with which configuration? I haven´t managed it yet.
CODE 6.4
set_name='collabora'
set_core_regex='cp-6.4'
set_online_regex='co-6-4'
lo_src_repo='https://github.com/LibreOffice/core.git'
lo_src_branch='distro/collabora/cp-6.4'
lo_src_commit=''
lo_src_tag='cp-6.4-6'
lo_dir="/opt/libreoffice"
lo_forcebuild=true # force compilation
lo_non_free_ttf=true
poco_version=$poco_version_latest
poco_forcebuild=false
lool_src_repo="https://github.com/LibreOffice/online.git"
lool_src_branch='distro/collabora/co-6-4'
lool_src_tag='cp-6.4.0-3'
lool_dir="/opt/lool"
lool_configure_opts="--disable-werror --with-lokit-path=${lo_dir}/include"
lool_logfile='/var/log/loolwsd.log'
lool_prefix='/usr'
lool_sysconfdir='/etc'
lool_localstatedir='/var'
lool_forcebuild=true
lool_maxcon=200
lool_maxdoc=100
loolwsd_service_name='loolwsd'
@DmDS does the creation of new documents via templates work for you?
@DmDS does the creation of new documents via templates work for you?
unfortunately not...
@DmDS does the creation of new documents via templates work for you?
For me it´s working now. I have tested it with PowerPoint.
Im now on version 6.4.6, but i cant see anything of the new UI.
Whats the last working config on debian This one ? ####################################### set_core_regex='cp-6.0$' set_online_regex='collabora/collabora-online-4-0-4$' lo_src_branch='distro/collabora/cp-6.0' lo_src_tag='cp-6.0-30' #######################################