the method name onReshape for OpenGLCanvas is a little awkward. The shape could be considered as either dimensions of the existing shape, or a literal shape (oval, square, rectangle, triangle, etc). The shape will always be a rectangle, but the dimensions can change. Perhaps rename to OpenGLCanvas#onSizeChange()?
Or the user could just bind to the widthproperty/heightproperty that JavaFX already provides for us as this is a member of the Region class, which makes a size change callback redundant.
husker-dev
commented
2 years ago
the method name onReshape for OpenGLCanvas is a little awkward. The shape could be considered as either dimensions of the existing shape, or a literal shape (oval, square, rectangle, triangle, etc). The shape will always be a rectangle, but the dimensions can change. Perhaps rename to OpenGLCanvas#onSizeChange()?
Or the user could just bind to the widthproperty/heightproperty that JavaFX already provides for us as this is a member of the Region class, which makes a size change callback redundant.