search

husnjak / IGDB-SWIFT-API

A Swift wrapper for the IGDB.com Free Video Game Database API.
MIT License
60 stars 12 forks source link

Swift 5? #4

Closed juavazmor closed 4 years ago

juavazmor commented 5 years ago

I'm trying to build a quick app using Swift 5 and I can't get it working. Do you have any plans of upgrading it to the last version?

Thanks for your work!

husnjak commented 5 years ago

I'll look into the issue, but I have set the swift project version as Undefined so it should work. What issue are you getting?

juavazmor commented 5 years ago

Looks like the problem is coming because a dependency called "Just". "Pods/Just/Just.swift"

In multiple lines there are Strings still using the deprecated "characters" property. This one is easy to fix but... In lines 331 and 334 of the same file I got two more errors:

Cannot convert return expression of type 'Dictionary<Key, Value>.Keys' to return type 'LazyMapSequence<[Key : Value], Key>' Cannot convert return expression of type 'Dictionary<Key, Value>.Values' to return type 'LazyMapSequence<[Key : Value], Value>'

husnjak commented 4 years ago

The package has been updated and should work with swift 5 now