husonlab / megan-ce

MEGAN Community Edition
GNU General Public License v3.0
65 stars 22 forks source link

Altering calls to sis-jhdf5 #16

Open pgrt opened 2 years ago

pgrt commented 2 years ago

Hi,

I am working on getting megan-ce packaged into Debian. I noticed that some calls to sis-jhdf5 refer to non-existing methods. For instance, in src/megan/biom/biom2/Biom2ParserTest.java, the reader object (line 76) does not have a readStringMDArray method and does not inherit one, resulting in a build failure.

I propose the enclosed patch, which solves all such calls.

altering_calls_to_sis-jhdf5.txt

By the way, you can consider upgrading to version 19.04.0 of sis-jhdf5, I successfully used it for the Debian build.

Best wishes,

Pierre