hussachai / play-scalajs-showcase

Play+Scala.js Showcase
Do What The F*ck You Want To Public License
125 stars 41 forks source link

Some enhancements and refinements #7

Closed epabst closed 8 years ago

epabst commented 8 years ago

These are some changes I found useful in my own development based on this project that I'd like to contribute back if you're interested. Feel free to take any subset of these commits if you have concerns with any, just make a comment on this pull request so that I can rebase it as needed.

hussachai commented 8 years ago

It seems like you made a lot of changes. Thanks a lot :) I'll take a look at it this weekend.

hussachai commented 8 years ago

I don't know why you want to add Gremlin/Neo4j as a data store for Todo Task. It's a graph database , and I don't think it represents a good use case for graph database here. Key-value store like Redis is also a choice to be an alternative data store. However, the purpose of this project is to demonstrate how to use Scala.js with Playframework. Slick and Anorm that I added are also outside of the scope of this project ;P I'll accept this pull request, but I can't promise that I will not remove it in the future. Thanks a lot for sharing, and I hope you're having fun with Scala.js like I did.

epabst commented 8 years ago

Fair enough. Thanks!