Closed GoogleCodeExporter closed 8 years ago
As for MockOAuthDataStore::new_access_token() and
MockOAuthDataStore::new_request_token(), these should be updated to take
advantage
verification needed to be in line with 1.0a spec.
In the mean time, do you have any examples on how to make sure it is secure?
Original comment by andre.ro...@gmail.com
on 20 Apr 2010 at 2:04
I'll look into fixing the notices in OAuth.php and in the unit tests. The
examples should really be updated to
some that better illustrate how to use the different things..
Original comment by morten.f...@gmail.com
on 7 May 2010 at 3:26
OAuth.php should no longer give any warning as of revision 1230.
MockOAuthDataStore.php should no longer give any as of revision 1232.
Example-code is outdated and I didn't want to fix a minor issue with something
that needs to be replaced anyways..
The new mock datastore still doesn't use the verifier/callback for anything,
because it is only a mock store to test if signatures are dealt with correctly.
I will eventually produce some new examples that shows it off..
-Morten
Original comment by morten.f...@gmail.com
on 12 Jun 2010 at 8:37
There is a minor left over in rv 1232:
http://code.google.com/p/oauth/source/detail?r=1232
This line is not needed anymore:
$port or $port = ($scheme == 'https') ? '443' : '80';
as it has been tackled by :
$port = isset( $parts['port'] ) && $parts['port'] ? $parts['port'] : ( $scheme
=== 'https' ? '443' : '80' );
Original comment by andre.ro...@gmail.com
on 12 Jun 2010 at 2:21
Removed the extra line.. Thanks for spotting it..
Original comment by morten.f...@gmail.com
on 13 Jun 2010 at 7:52
Original issue reported on code.google.com by
andre.ro...@gmail.com
on 20 Apr 2010 at 11:21