search

hussainweb / drupal-composer-helper

Common scripts used with Drupal
MIT License
5 stars 1 forks source link

Add support for npm-asset and bower-asset #10

Closed hussainweb closed 4 years ago

hussainweb commented 6 years ago

Since this is commonly used, we can add these to defaults set by this plugin. This should not interfere with anything if it's not used.

The change has to be done \Hussainweb\DrupalComposerHelper\ComposerInstallersHelper. A challenge is handling this in the \Hussainweb\DrupalComposerHelper\ComposerInstallersHelper::installerPaths array as that is an inverted structure of how composer.json defines it. Either we have to add processing to correctly invert and merge array keys into values OR we should set this to how we would find it in composer.json.

hussainweb commented 6 years ago

This would need oomphinc/composer-installers-extender package to allow defining additional types (or we could do it).

hussainweb commented 4 years ago

Supporting it in the installers is not feasible in the current version because of how we are automatically setting the drupal- prefix on the types (bad decision on my part back at that time). Since the pay-off is minimal, I am dropping the requirement and only going to suggest the package.