hussein4alaa / laravel-g4t-swagger-auto-generate

auto generate swagger in laravel
MIT License
106 stars 13 forks source link

Bumps dependencies for laravel And optimize code some traits And Fix some error when testing #14

Closed waadmawlood closed 1 year ago

waadmawlood commented 1 year ago

1 - Bumps dependencies laravel 7,8,9,10 Use ("illuminate/routing") will require the list of illuminate dependency (https://github.com/waadmawlood/laravel-g4t-swagger-auto-generate/commit/2ec6058bb15042bc2b6c33623f9cbe502badd11e)

2 - Optimize code of some traits (https://github.com/waadmawlood/laravel-g4t-swagger-auto-generate/commit/2ec6058bb15042bc2b6c33623f9cbe502badd11e) (https://github.com/waadmawlood/laravel-g4t-swagger-auto-generate/commit/7b4d7a0e645385d1714eee50a7726428941e53cf) (https://github.com/waadmawlood/laravel-g4t-swagger-auto-generate/commit/5f9374b7d9a0e0fc46e0d9193ff9a60e34acc088) 3 - Fix the error missing some helper string (Str) in laravel 7 (https://github.com/waadmawlood/laravel-g4t-swagger-auto-generate/commit/65fe91c874d5025738009ed1ee1fd014e21b47e9)

hussein4alaa commented 1 year ago

Hello waadmawlood

Thank you for your contribution to the laravel-g4t-swagger-auto-generate. I appreciate the time and effort you've put into the pull request #14. However, after a thorough review, it seems that the changes introduced in this pull request are causing issues within the schema.

We've identified issues with Schema. It's crucial for us to maintain a stable and reliable schema, as it forms the core of our project.

We encourage you to revisit the changes and address the schema issues. If possible, please provide alternative solutions or adjustments that would ensure the proper functioning and data integrity of the schema.

Your contribution is valued, and we believe that with some adjustments, your changes can positively impact the project. Please feel free to resubmit the pull request once the schema issues have been resolved.

Thank you again for your dedication to improving our project.