husseinaluie / FlowSieve

FlowSieve coarse-graining code base
https://flowsieve.readthedocs.io/en/latest/
Other
18 stars 9 forks source link

Running the basic tutorial #14

Closed NoraLoose closed 1 year ago

NoraLoose commented 1 year ago
EXTEND_DOMAIN_TO_POLES = false

I think it would be useful to include this in the docs too.

This issue is part of the JOSS review process over at https://github.com/openjournals/joss-reviews/issues/4277.

bastorer commented 1 year ago

Making notebook versions of the tutorial python scripts is a good idea!

I'm not very familiar with conda, but agree that giving explicit library dependencies would be helpful. I'll look into those this week.

NoraLoose commented 1 year ago

Let's try to work toward closing this issue.

bastorer commented 1 year ago

Notebook added :-)

I've added an environment file listing the versions that I used why I ran the tutorials. I'm not very familiar with .yml files, but I think I've got it formatted correctly.

NoraLoose commented 1 year ago

You can check whether your conda environment works correctly by following the steps here.

bastorer commented 1 year ago

I'm running into permissions issues with conda env. I'll try switching to a different server to see if I can test the environment there :-)

bastorer commented 1 year ago

I've got the conda environment working on the other server :-) I'm having some trouble getting it to play nice when I try to activate the environment inside of submitted jobs, but otherwise running in command-line in the activated environment reproduces the tutorial figures

bastorer commented 1 year ago

Hi Nora,

With the environment.yml and jupyter notebooks set up, is there anything else that you think needs to be addressed for this ticket?

Thanks!

NoraLoose commented 1 year ago

Cool, I just tested the conda environment, and am able to run all python scripts. Closing this issue!