Closed NoraLoose closed 1 year ago
Making notebook versions of the tutorial python scripts is a good idea!
I'm not very familiar with conda, but agree that giving explicit library dependencies would be helpful. I'll look into those this week.
Let's try to work toward closing this issue.
environment.yml
for the required python dependencies (for all tutorials together, so I would place it here with some instructions) would be very helpful - then I can also tick off the following reviewer box :)
Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
Notebook added :-)
I've added an environment file listing the versions that I used why I ran the tutorials. I'm not very familiar with .yml files, but I think I've got it formatted correctly.
You can check whether your conda environment works correctly by following the steps here.
cmocean
is missing in the environment.yml
file. There may be other packages missing. Could you check if all tutorials are running after activating the FlowSieve-tutorial-env
environment? Thanks!I'm running into permissions issues with conda env. I'll try switching to a different server to see if I can test the environment there :-)
I've got the conda environment working on the other server :-) I'm having some trouble getting it to play nice when I try to activate the environment inside of submitted jobs, but otherwise running in command-line in the activated environment reproduces the tutorial figures
Hi Nora,
With the environment.yml and jupyter notebooks set up, is there anything else that you think needs to be addressed for this ticket?
Thanks!
Cool, I just tested the conda environment, and am able to run all python scripts. Closing this issue!
constants.hpp
, I modified variables as in the documentation, but in addition needed to make the following modification:I think it would be useful to include this in the docs too.
environment.yml
file to set up a conda environment.but you could also consider to make the 2 python scripts more interactive and step through them in the notebook.
This issue is part of the JOSS review process over at https://github.com/openjournals/joss-reviews/issues/4277.