husseinaluie / FlowSieve

FlowSieve coarse-graining code base
https://flowsieve.readthedocs.io/en/latest/
Other
18 stars 9 forks source link

Scalar Tutorial #19

Closed NoraLoose closed 1 year ago

NoraLoose commented 1 year ago

Just two quick questions regarding the "Scalar Tutorial":

Tagging https://github.com/openjournals/joss-reviews/issues/4277

bastorer commented 1 year ago

Thanks for catching those. FiniteDiff was not needed (and has been removed) and the submit script has been updated to match the run_all_steps script :-)

NoraLoose commented 1 year ago

Great, thanks for fixing these.

My last (but optional) suggestion for the scalar tutorial is that you could plot rho_orig in the jupyter notebook before showing the 3 decompositions into coarse and fine fields.

bastorer commented 1 year ago

Good idea, I've added the figure :-)

NoraLoose commented 1 year ago

Cool, I am closing this issue.