husseinaluie / FlowSieve

FlowSieve coarse-graining code base
https://flowsieve.readthedocs.io/en/latest/
Other
18 stars 9 forks source link

Add a copy of `constants.hpp` with the specific values in Tutorials #28

Closed ashwinvis closed 1 year ago

ashwinvis commented 1 year ago

This is not a bug, but a suggestion. The number of parameters to go around and edit manually to get through the tutorial is a lot and I had to change it for every tutorial.

I think a new user would be best served by a copy of the constants.hpp file. Ther may also be other solutions to quickly get started

bastorer commented 1 year ago

That's an excellent suggestion. Having a constants.hpp file in each tutorial, as well as a couple constants file for typical use cases would help soften the learning curve for using FlowSieve. I'll make those this week :-)

bastorer commented 1 year ago

The constants files are now included in each tutorial case :-)

ashwinvis commented 1 year ago

Thanks! It looks good.