search

husseycoding / cartrulefix

Magento 1.9 CE Shopping Cart Price Rule Fix
16 stars 10 forks source link

Magento CE 1.9.2 #1

Open seansan opened 9 years ago

seansan commented 9 years ago

Saw your twitter about Magento CE 1.9.2 first (in Google). Nice!

Did they include this fix in 1.9.2?

husseycoding commented 9 years ago

The problem was actually documented as being fixed in version 1.9.1.0 CE although the core 'fix' was actually just to disable the stop further rules processing logic altogether. This module actually fixes the issue while also allowing the stop further rules processing logic to still run.

I don't know if there will be a proper fix in place for 1.9.2.0 CE as it's not available to download for another few weeks yet but I'm not expecting any other core changes to the class in question. I'll leave the ticket open however and check back at some point after 1.9.2.0 CE is available.

seansan commented 9 years ago

Thanks. Question: did you every post it as a fix? Just wondering if there is a logical fix if they pick something like that up. I mean why not?

On Fri, Apr 24, 2015 at 3:30 PM, Jonathan Hussey notifications@github.com wrote:

The problem was actually documented as being fixed in version 1.9.1.0 CE although the core 'fix' was actually just to disable the stop further rules processing logic altogether. This module actually fixes the issue while also allowing the stop further rules processing logic to still run.

I don't know if there will be a proper fix in place for 1.9.2.0 CE as it's not available to download for another few weeks yet but I'm not expecting any other core changes to the class in question. I'll leave the ticket open however and check back at some point after 1.9.2.0 CE is available.

— Reply to this email directly or view it on GitHub https://github.com/husseycoding/cartrulefix/issues/1#issuecomment-95932484 .

jay-saint commented 9 years ago

Magento CE 1.9.2.0 is now released with full release notes available here: http://merch.docs.magento.com/ce/user_guide/Magento_Community_Edition_User_Guide.html#magento/release-notes-ce-1.9.2.html

In my initial reading of the notes I do not see any changes specifically related to this bug. There are a ton of other great fixes and security fixes.

seansan commented 6 years ago

Maybe you can post your fix here? https://github.com/OpenMage/magento-lts