hust-diangroup / ns3-ai

Enable the interaction between ns-3 and popular frameworks using Python, which mean you can train and test your AI algorithms in ns-3 without changing any frameworks you are using now!
GNU General Public License v2.0
220 stars 80 forks source link

Convenience extensions on old API, Version 2.0 #100

Open Flunzmas opened 11 months ago

Flunzmas commented 11 months ago

Hey there,

In my own fork I have made several small convenience improvements in the branch flunzmas_ns3.36 to suit my own requirements:

Most of them should be unproblematic changes and potentially be useful to others, so I'd like to merge these changes. However, in the meantime you folks have done a lot of awesome new work, to the point where most of the files modified by me don't even exist anymore. I can't properly open a PR on the main branch because I don't yet know where to look for, and have instead opened a PR on the old master branch (#101).

I would be very grateful if you could provide me some guidance in integrating these changes into the main branch and pack everything into a new release that comes with its own commit tag. I think it's reasonable to make it version 2.0 since the API seems very different now.

Thanks for your work!

Flunzmas commented 9 months ago

Hi, has any of the maintainers had the time to look as the proposed changes yet?