Stream downloads are broken.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Add to examples/FBTestPlugin/test.html the next code after line number 194:

alert("Stream Result: " + plugin.testStreams());

2. Open examples/FBTestPlugin/test.html with the browser (firefox, chrome or 
IE).

What is the expected output? What do you see instead?

I expect that streams works fine and I expect to receive logical stream's 
events sequence when successfully or failed:

On success:

1. DefaultBrowserStreamHandler::onStreamCreated()
2. DefaultBrowserStreamHandler::onStreamOpened()
3. DefaultBrowserStreamHandler::onStreamDataArrived()
4. DefaultBrowserStreamHandler::onStreamCompleted()
5. DefaultBrowserStreamHandler::onStreamDestroyed()

On error:

1. DefaultBrowserStreamHandler::onStreamCreated()
2. DefaultBrowserStreamHandler::onStreamFailedOpen()
3. DefaultBrowserStreamHandler::onStreamCompleted()  (optional?)
4. DefaultBrowserStreamHandler::onStreamDestroyed()

or 

1. DefaultBrowserStreamHandler::onStreamCreated()
3. DefaultBrowserStreamHandler::onStreamCompleted()
4. DefaultBrowserStreamHandler::onStreamDestroyed()

What I see instead, depends the browser used:

1) Using FireFox 3.6.13, FireFox 4.0 b8 and Chrome v8.0.552.224:

I only receive DefaultBrowserStreamHandler::onStreamCreated() event.

2) Using IE v8.0.7600.16385:

I only receive DefaultBrowserStreamHandler::onStreamCreated() event when 
MyStreamHandler1 and MyStreamHandler3 handlers are used. Instead using 
MyStreamHandler2 I receive:

DefaultBrowserStreamHandler::onStreamCreated() and 
MyStreamHandler2::onStreamOpened(). But readRange( 100, 100 + 15 ) returns an 
error because isSeekable() fails at ActiveXStream::readRanges(). I receive no 
event more.

What version of FireBreath are you using? On what operating system and
browsers?

I'm using master branch from github commit 
13fcf8f7c1e777ca4002d00abb8784b5d3667006 and I have cherry pick the commit 
d1d0f0341f1356fc3c15d072d146d4dcd123fcd4 too.

I'm running in Windows 7 x64 bits and I use FireFox 3.6.13, FireFox 4.0 b8,  
Chrome v8.0.552.224 and IE v8.0.7600.16385

Please provide any additional information below.

Original issue reported on code.google.com by noant...@gmail.com on 29 Dec 2010 at 10:05

[GoogleCodeExporter]

Have you tried this with the latest from 1.4? There have been some significant 
changes to the streams in 1.4 that may have fixed this issue.

Original comment by rich...@firebreath.org on 7 Jan 2011 at 4:38

• Changed state: Accepted

[GoogleCodeExporter]

No, I did not. I will try to test it this weekend, otherwise I'll check it on 
Monday.

Original comment by noant...@gmail.com on 7 Jan 2011 at 8:57

[GoogleCodeExporter]

I have tested the FBTestPluginAPI::testStreams() using the master git branch 
and the commit 57f2c49c357697bfa78202c6e0273fcbd5d9dbe8 (lastest 1.4 version), 
but the streams still do not work running. 
I tested on FireFox 3.6.13, FireFox 4.0 b8 and Chrome v8.0.552.224 (in all 
tests I have used Debug version). Testing FBTestPlugin on IE v8.0.7600.16385 I 
get another error, an assert happens running FBTestPluginAPI at PluginCore.cpp 
line 111.

Note: I have not tested in release mode.

Original comment by noant...@gmail.com on 10 Jan 2011 at 11:29

[GoogleCodeExporter]

I've updated my plugin to 1.4 (nightly 74). It's downloading streams 
successfully from IE8 and FF3.6 on Win7. I've handlers for stream created, 
opened, data received, and completed. So, I can confirm these events are 
properly sent.

Original comment by kcs...@gmail.com on 13 Jan 2011 at 8:53

[GoogleCodeExporter]

Hi kcsham,

Which git's branch are you using? Which commit (hash number)?

Best regards.

Original comment by noant...@gmail.com on 13 Jan 2011 at 9:19

[GoogleCodeExporter]

It sounded like we my have resolved this is an issue with not holding a 
reference to the stream objects until the download completed; is this correct?

Original comment by richarda...@gmail.com on 29 Jan 2011 at 2:05

• Changed state: Recheck

[GoogleCodeExporter]

I'm afraid that I'm experiencing similar symptoms with 1.4b3. Stepping through 
the code, it looks like only 2 observers are being registered by the base class 
(DefaultBrowserStreamHandler) though my derived class overrides all event 
handlers. It appears that just as I'm about to receive a data event, 
BrowserStreamManager calls its onStreamCompleted() handler and removes my 
observers.

Original comment by Geoff.Cu...@rogers.com on 31 Jan 2011 at 2:07

[GoogleCodeExporter]

Keep in mind that BrowserStreamManager only removes defunct weak_ptrs and it's 
own handler, so if your handler is gone after that then you have failed to 
retain your own shared_ptr to the observer.

This is by design; there is no hard link between the stream and your observer 
so if your observer goes away early for whatever reason it doesn't cause a 
crash.  Try saving a shared_ptr to your observer in your class and see if the 
problem goes away.

Original comment by taxilian on 31 Jan 2011 at 2:10

[GoogleCodeExporter]

That was the problem. Thanks!

Original comment by Geoff.Cu...@rogers.com on 31 Jan 2011 at 3:24

[GoogleCodeExporter]

I'm going to mark this resolved, then; we'll need to add that to the docs.

Original comment by taxilian on 31 Jan 2011 at 3:30

• Changed state: Fixed