No new line at the end of some source files

[GoogleCodeExporter]

Some of the FB source files don't end with new line and g++ would complain 
about it.

Original issue reported on code.google.com by zbynek.m...@nic.cz on 20 Jan 2011 at 11:55

[GoogleCodeExporter]

yeah, I've been trying to watch for that, but I forget sometimes.  Feel free to 
fix in a fork and request a pull ;-)

I'll get to this one.

Original comment by taxilian on 20 Jan 2011 at 3:47

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Hmm. I'm not getting any warnings when I build with g++.  What versions are you 
using?

Original comment by richarda...@gmail.com on 23 Jan 2011 at 2:29

[GoogleCodeExporter]

It's g++ 4.0.3 from Ubuntu 6.06 (I use it to make FB compatible with older 
glibc versions). I know that newer g++ versions could be ok (I cannot see any 
warning on my Debian unstable with g++ 4.4.5).

Original comment by zbynek.m...@nic.cz on 24 Jan 2011 at 8:58

[GoogleCodeExporter]

Hmm.  Without an easy tool to track this down and it not being a problem on 
recent versions, I'm inclined to leave it.  It's just warnings, not actual 
errors, correct?

Alternately, if you want to fix it and provide a patch I would be happy to 
accept it.  If you can even just send me a list of files to look at I can 
probably come up with something.

Original comment by richarda...@gmail.com on 24 Jan 2011 at 5:16

[GoogleCodeExporter]

Compiler could get into a trouble. See 
http://stackoverflow.com/questions/72271/no-newline-at-end-of-file-compiler-warn
ing

Original comment by zbynek.m...@nic.cz on 26 Jan 2011 at 1:55

[GoogleCodeExporter]

These issues are fixed in pretty much all currently used compilers, though I do 
agree that it is a good practice to follow anyway (particularly for any who 
need to use an older compiler to target older systems).

I will have to find an easy way to scan for this.  If you know one let me know, 
otherwise it may take me some time until I can get to this.  Since it's a 
relatively simple problem to solve and affects a relatively small percentage of 
users it will have to wait until I have finished some more critical issues; I 
will, however, make sure to have it figured out before the 1.4 release!

Original comment by richarda...@gmail.com on 29 Jan 2011 at 2:07

[GoogleCodeExporter]

This is fixed.

Original comment by taxilian on 26 Feb 2011 at 7:12

• Changed state: Fixed