fix Dutch translation from `binnenkort` to `zojuist`

hustcc / timeago.js

:clock8: :hourglass: timeago.js is a tiny(2.0 kb) library used to format date with `*** time ago` statement.

https://timeago.org

MIT License

5.3k stars 411 forks source link

fix Dutch translation from `binnenkort` to `zojuist` #210

Closed mvdwaeter closed 4 years ago

mvdwaeter commented 4 years ago

This PR fixes a Dutch translation for timestamps that are less than 1 second ago. The old translation "binnenkort" translates to "in the near future", which is wrong. I changed it to "zojuist" which translates to "recent"

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 489

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.89%

Totals
Change from base Build 488:	0.0%
Covered Lines:	448
Relevant Lines:	680

💛 - Coveralls

mvdwaeter commented 4 years ago

When accepted, is it possible to make a minor release for the v2, e.g. v2.0.6? this would help me a lot :)

hustcc commented 4 years ago

Why not to upgrade to v4, just a little time 😂

mvdwaeter commented 4 years ago

If accepted, can this be released as

Why not to upgrade to v4, just a little time 😂

That's because timeago.js is a dependency, on a third-party software we use (coral-talk) that pins it's timeago.js dependency as:

"timeago.js": "^2.0.3",

So a version 2.0.6 should automatically be picked up without writing a patch.

mvdwaeter commented 4 years ago

Actually, I just realised I made a mistake, there are two columns, one for "x seconds ago" and one for "within x seconds". Other than that, the error I was trying to fix regarded a timestamp from the server that was compared with a timestamp of the client. Hence, a discrepancy can exist, which results in timestamps from the past are seen as timestamp from the future..