hustcc / timeago.js

:clock8: :hourglass: timeago.js is a tiny(2.0 kb) library used to format date with `*** time ago` statement.
https://timeago.org
MIT License
5.29k stars 411 forks source link

Incorrect future approximation? #236

Open AnandChowdhary opened 3 years ago

AnandChowdhary commented 3 years ago

Today is January 19 2021, when I do format('2023-01-19T14:23:07.418Z', 'en_US'), which is exactly 2 years (minus some minutes), the rendered result is "1 year" instead of "2 years".

Most likely, this is because the current time (hours/minutes) is after 14:23, so it's actually 1 year, 364 days, 20 hours. I think this should be "rounded" to 2 years rather than 1 year, but perhaps this is a judgement call.

Super curious to hear your opinion!

matheusbaumgart commented 3 years ago

Have the same issue in hours, which is preventing me from using this awesome lib. Here is the issue: If the time is 2:01 and there is an "event" at 4:00 it will say: in 1 hour. Assuming because it's actually 1h and 59min until the "event". Since minutes are not shown, the estimation is misleading.

How do I show the minutes?