search

hustcc / timeago

:hourglass: Simple library used to format datetime with `*** time ago` statement. eg: "3 hours ago".
http://timeago.org
MIT License
223 stars 37 forks source link

PL rewrite #24

Closed lolobosse closed 5 years ago

lolobosse commented 5 years ago

Hey, I saw that #23 wasn't merging because of some issues with external grammar files so I tried to fix them.

Could @hustcc, @marcel-odya and others took a look at it?

I'm not extremely proud of the design but it does the work and the whole locale logic lives in one and only file. 💪

Btw @marcel-odya, thanks for the work, it was awesome! 👍 🙏

hustcc commented 5 years ago

I have not write python for years, do you has some time to maintain the librarr, include:

lolobosse commented 5 years ago

@hustcc I'm already maintainer of the project, but you had some issues with the existing PR; that's why I'm asking if it suits better. If yes, I'll release 1.0.9 with PL in it.

marcel-odya commented 5 years ago

Sorry guys for not giving feedback earlier. I've been pretty busy these days. @lolobosse it looks great if you ask me. I guess it's better that way, regarding it all sits in one file now and is easier to grasp.