hustille / ComfyUI_Fooocus_KSampler

Fooocus KSamplerWithRefiner as a ComfyUI node
GNU General Public License v3.0
60 stars 11 forks source link

[question] - no refiner workflow #3

Closed tastez closed 1 year ago

tastez commented 1 year ago

in case we don't want to use a refiner - do we just plug the same model for the refiner, and set "refiner switch steps" to 1 and up the samples for the "steps"

hustille commented 1 year ago

You can use the same model. In that case _refiner_switchstep is more or less irrelevant. Don't change steps, that is the combined value. The sampler runs from step 0 to _refiner_switchstep on model and from _refiner_switchstep to steps on _refinermodel. If you set _refiner_switchstep to 0 or > steps it will not switch.

hustille commented 1 year ago

Why not just a standard sampler? Do you have any insight into the changes Fooocus makes? In the tests I have run the differences were minimal.

tastez commented 1 year ago

hmm good point. I had no idea actually and assumed it is different in some way. I am not changing start_at_step / end_at_step but I am plugging in the same model and changing steps to 8+ and refiner to 1 and it feels like sdxl without a refiner. thanks for reply!

hustille commented 1 year ago

It is different. I just have no idea under what circumstances those differences become relevant or at least visible. It's possible that I have overlooked something and there are still differences in Fooocus which I haven't pulled over, but I don't think so.

The only major thing is the sharpness parameter, which does some local modifications without changing the overall picture. Useful values seem to go up to 20 or so, just play around with it.

tastez commented 1 year ago

yeah great. thanks a ton for this node its great and compact!