hustvl / 4DGaussians

[CVPR 2024] 4D Gaussian Splatting for Real-Time Dynamic Scene Rendering
https://guanjunwu.github.io/4dgs/
Apache License 2.0
2.27k stars 188 forks source link

About opacity_final #23

Closed YutingXiao closed 1 year ago

YutingXiao commented 1 year ago

Thanks for the excellent work.

I observe that the scale_final, mean3D_final, and rotation_final (in 4DGaussians/gaussian_renderer/init.py) are used for rendering, but the "opacity" is used instead of "opacity_final." And the "opacity_final" has no place to use.

I have no idea about this. Can you tell me why?

rendered_image, radii, depth = rasterizer(
    means3D = means3D_final,
    means2D = means2D,
    shs = shs,
    colors_precomp = colors_precomp,
    opacities = opacity,
    scales = scales_final,
    rotations = rotations_final,
    cov3D_precomp = cov3D_precomp)

(Line 117)

guanjunwu commented 1 year ago

hahaha because the code is still under development. If you use opacity_final and fix the typo in the code, you will find the rendering quality may rise by ~1PSNR in Neu3D dataset. We will fix it all after CVPR deadline.