search

hustvl / 4DGaussians

[CVPR 2024] 4D Gaussian Splatting for Real-Time Dynamic Scene Rendering
https://guanjunwu.github.io/4dgs/
Apache License 2.0
2.26k stars 189 forks source link

Coarse "render_process" using fine standard #79

Closed baitingzbt closed 9 months ago

baitingzbt commented 10 months ago

When render_process runs at coarse stage, I think the stage is actually passed in as coarsetrain or coarsetest, which causes the gaussian_renderer believe it should follow the fine-stage standard. Is this intended?

Here returns false, perhaps need a start.startswith('coarse'): https://github.com/hustvl/4DGaussians/blob/d412f8b22d107f65961c334f594dea81f6338580/gaussian_renderer/__init__.py#L80

Here is where stage being passed in: https://github.com/hustvl/4DGaussians/blob/d412f8b22d107f65961c334f594dea81f6338580/train.py#L239

guanjunwu commented 10 months ago

thank you for pointing out the bug! in fact, it maybe should be changed to if "coarse" in stage

guanjunwu commented 9 months ago

Hi, i've solve the problem in the latest version. Please feel free to contact me if you have other problem.