search

hutchy2570 / chrometophone

Automatically exported from code.google.com/p/chrometophone
0 stars 0 forks source link

small glitches in OAuth.js #364

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
1) The variable pLen is not defined in OAuth.js line 1050.
http://code.google.com/p/chrometophone/source/browse/trunk/third_party/firefox_s
endtophone/modules/OAuth.js#1050

Please add "var " to the beginning of the line.
  var pLen = paramNames.length;

2) Instead of assigning you test for equality in line 768
  http://code.google.com/p/chrometophone/source/browse/trunk/third_party/firefox_sendtophone/modules/OAuth.js#768

Please replace 
  this._parameters['oauth_version']=='1.0';
by
  this._parameters['oauth_version']='1.0';

-Axel

Original issue reported on code.google.com by ignisvul...@gmail.com on 29 Aug 2011 at 8:15

GoogleCodeExporter commented 9 years ago 
That code is part of the OAuthSimple from http://unitedheroes.net/OAuthSimple/ 
You should report it to him so that all the projects that use the library can 
be fixed.

I've committed them to FoxToPhone in [295]

Original comment by aml...@gmail.com on 30 Aug 2011 at 8:30