huths0lo
commented
9 months ago Thank you for the feedback. I'm planning to keep chipping away at it, to get it be more automated. Basically the goal is to make it as simple as a pip install, and then running a setup to set the needed variables. I'll probably start a new branch and begin working on that in the next couple of days. For now, I really just wanted to get the first round of code out there, so people could use it if they like. Knowing what I learned through this process, I think there could be some really compelling use cases way beyond what I wrote it for.
I'll definitely refactor and reorganize it as I go. Most of my code to date has been closed source. So I cant say that I've had many people actually read it before :)
On Fri, Dec 8, 2023 at 2:06 PM Alejandro González Momblán < @.***> wrote:
Hi there,
I love the idea of the project and it is very interesting and definitely helps you on your daily shopping (and it surely can be expanded to other markets as well).
I've taken a look at the code and it can be improved in terms of readability and maintainability. I highly recommend creating new modules and adding docstrings everywhere. That will help you in further development and also will make other people understand the code easily. Finally, you could encapsulate all the project in a package so it can be distributed and managed effortless.
Anyway, the project looks nice the way it is right now. Congratulations for the result and the job done!
— Reply to this email directly, view it on GitHub https://github.com/huths0lo/SavonPython/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZQAMBPQH4J3PCCJNJPEQLYIOFN3AVCNFSM6AAAAABANH6HG6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTGMZWG43DQOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
YisusChrist
Hi there,
I love the idea of the project and it is very interesting and definitely helps you on your daily shopping (and it surely can be expanded to other markets as well).
I've taken a look at the code and it can be improved in terms of readability and maintainability. I highly recommend creating new modules and adding docstrings everywhere. That will help you in further development and also will make other people understand the code easily. Finally, you could encapsulate all the project in a package so it can be distributed and managed effortless.
Anyway, the project looks nice the way it is right now. Congratulations for the result and the job done!