huttotw / homebridge-kia-connect

Connect your Kia vehicle to HomeKit
Apache License 2.0
13 stars 1 forks source link

Expand setup configuration #8

Open johnsills1 opened 6 months ago

johnsills1 commented 6 months ago

Would it be possible to expand the configuration page to allow us to disable certain aspects of the plugin. For example, the Temperature Sensor must not be available on my Kia Stinger. I have the Kia Connect Ultimate and the only temperature reading I ever see is 32 degrees and it never changes.

Great work on the Plugin by the way. This is really cool.

johnsills1 commented 6 months ago

Just to elaborate, homebridge is receiving a NaN (number) from my Stinger for the Temperature reading.

asabatino88 commented 6 months ago

Agreed - would also be good to extend the remote start time to 10 minutes from 5 minutes. It looks like there's a setting in client.ts that would allow this extension. I also note that the Home Assistant plugin lets you choose 10 minutes. I like the ease of this plugin vs the Home Assistant one, so I haven't fully moved over yet.

johnsills1 commented 6 months ago

I had another idea for the plugin. Would it be possible to take the battery status percentage and create something like a light sensor so we could use the percentage in an automation to warn us when the battery drops below a certain percentage. I already had to change my car battery after one year (strange) so I’ve been watching this data. It’s just buried in the engine accessory settings

huttotw commented 5 months ago

Hey @johnsills1 and @asabatino88 sorry for the delay. I think these would be great additions to the plugin. I think all we would need to do is add some fields to the config.schema.json file so they can be filled in by the user upon installation, then we should use those as parameters throughout.

We should take the opportunity to add some tests here. I might work on this shortly!

huttotw commented 5 months ago

@johnsills1 let me know what you think of #11

johnsills1 commented 5 months ago

Looks good to me. I’m not a code writer, but I love beta testing, haha

John Sills

On Tue, Mar 12, 2024 at 7:57 PM Trevor Hutto @.***> wrote:

@johnsills1 https://github.com/johnsills1 let me know what you think of

11 https://github.com/huttotw/homebridge-kia-connect/pull/11

— Reply to this email directly, view it on GitHub https://github.com/huttotw/homebridge-kia-connect/issues/8#issuecomment-1992893933, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOLG7ZRZJBX5YWHRM67KD3YX6QAFAVCNFSM6AAAAABDRWEAEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSHA4TGOJTGM . You are receiving this because you were mentioned.Message ID: @.***>

asabatino88 commented 5 months ago

For what it's worth, I'm also experiencing the NaN on the external temperature sensor (which means it just defaults to 32 degrees all the time). I tried to comment out all of the external temperature sensor code in my forked code base, but wasn't able to stop it from showing up as an accessory in Homebridge. I'm not a dev but have done some basic coding over the years, so I was likely just missing something when playing around with it.

johnsills1 commented 5 months ago

How are the updates coming? I am hoping we can expose the battery as a light brightness sensor so we can utilize it in automations without jumping through hoops with the Eve, Controller for HomeKit and Home apps. Thanks

johnsills1 commented 1 month ago

Have you had time to work on this?