huuanh1987 / facebook-java-api

Automatically exported from code.google.com/p/facebook-java-api
0 stars 0 forks source link

Revision 484 breaks desktop mode functionality. #186

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

The chnage in revision 484 of /trunk/facebook-java-api/src/main/java/com/
google/code/facebookapi/ExtensibleClient.java file breaks the desktop mode 
behavior. The current secret is not the app secret but the user's secret.

This is how the function should be:
    private String generateSignature( List<String> params, boolean 
requiresSession ) {
        String secret = ( isDesktop() && requiresSession ) ? 
cacheSessionSecret : _secret;
        //String secret = _secret;
        return FacebookSignatureUtil.generateSignature( params, 
secret );
    }

Original issue reported on code.google.com by emailo...@gmail.com on 28 Mar 2009 at 3:11

GoogleCodeExporter commented 8 years ago
On the contrary, the code is now correct in my opinion. Please post some test 
code
that illustrates the scenario that is now failing for you. Thanks.

Original comment by david.j....@googlemail.com on 3 Apr 2009 at 3:03

GoogleCodeExporter commented 8 years ago

Original comment by david.j....@googlemail.com on 3 Apr 2009 at 3:04

GoogleCodeExporter commented 8 years ago

Original comment by david.j....@googlemail.com on 9 Apr 2009 at 1:39