search

huuck / ADBHoney

Low interaction honeypot designed for Android Debug Bridge over TCP/IP
GNU General Public License v3.0
160 stars 33 forks source link

added python3.6 support #33

Closed RayofLightz closed 4 years ago

RayofLightz commented 5 years ago

Ported the code base to python3.6 because 2.7 hits EOL soon. I tested the two supported commands adb shell and adb push and the code worked. I had to change the name of some imported modules and had to convert certain strings to bytes objects.

huuck commented 5 years ago

Hi!

It's crashing through certain adb push flows: image

Please test it with different file types (<64 bytes, >4MB and so on) and different network conditions, not only localhost stuff.

Let me know if you can/can't fix it, as the rest looks good.

Kindest regards, Gabriel

RayofLightz commented 5 years ago

Okay, will get to work on fixing it :)

RayofLightz commented 5 years ago

I just fixed the large file bug that was occurring. I had to add a check on recv_binary_chunk to stop an infinite loop that occurred. The program would hang and kept saying that it was receiving a chunk of 0 bytes

huuck commented 4 years ago

Only a few minor bugs which I'll fix. Going for the merge.