huuphuoc1396 / android-nimble-surveys

An application allows users to browse a list of surveys.
3 stars 0 forks source link

[Chore] Increase test coverage for the application #22

Closed minhnimble closed 11 months ago

minhnimble commented 11 months ago

Issue

It was great to see you have implemented multiple unit test cases for multiple layers like the Usecase (domain layer), ViewModel (app layer), Repository + Response classes (data layer). Now, it is a bit odd that you didn't write any unit tests for the HomeViewModel, which is the most important logic file in the application.

https://github.com/huuphuoc1396/android-nimble-surveys/blob/2b94876ed1f9fa6995dd5e0f2af7807f0cb85781/app/src/test/java/co/nimblehq/surveys/features/home/HomeViewModelTest.kt#L11-L27

Also, there is no instrumented test found in the application. It would be great if a few instrumented tests to verify some basic flows in the application could be provided.

Expect

huuphuoc1396 commented 11 months ago

Hi @minhnimble,

Kindly help me check it, Thank you!