search

huwenboshi / ImpG

Gaussian imputation of GWAS summary statistics
http://bogdan.bioinformatics.ucla.edu/software/impg/
14 stars 5 forks source link

ExtractPop script refers to undefined variable #2

Open YPHa opened 9 years ago

YPHa commented 9 years ago

the line: "if(indv not in added):" from: ImpG/ImpG-Utils/ExtractPop refers to the variable "added", which isnt defined anywhere else in the code.

huwenboshi commented 9 years ago

Hi YPHa,

Sorry for the late reply. You can fix the problem by adding:

added = set()

before line 24.

Sincerely,

Huwenbo Shi

On Wed, Jan 28, 2015 at 1:48 AM, YPHa notifications@github.com wrote:

the line: "if(indv not in added):" from: ImpG/ImpG-Utils/ExtractPop refers to the variable "added", which isnt defined anywhere else in the code.

— Reply to this email directly or view it on GitHub https://github.com/huwenboshi/ImpG/issues/2.

YPHa commented 9 years ago

hi Huwenbo, thanks for your response. i have fixed the script locally some time ago. i reported it in the hope of it getting fixed for other/future users who are not familiar with python. your suggested fix resolves the problem of the undefined variable but the code will not work correctly as the line: "added.add(indiv)" should also be added after the if statement on line 30. greetings, Yanick

From: Huwenbo Shi [notifications@github.com] Sent: Friday, January 30, 2015 01:57 To: huwenboshi/ImpG Cc: Hagemeijer, YP (thorax) Subject: Re: [ImpG] ExtractPop script refers to undefined variable (#2)

Hi YPHa,

Sorry for the late reply. You can fix the problem by adding:

added = set()

before line 24.

Sincerely,

Huwenbo Shi

On Wed, Jan 28, 2015 at 1:48 AM, YPHa notifications@github.com wrote:

the line: "if(indv not in added):" from: ImpG/ImpG-Utils/ExtractPop refers to the variable "added", which isnt defined anywhere else in the code.

— Reply to this email directly or view it on GitHub https://github.com/huwenboshi/ImpG/issues/2.

— Reply to this email directly or view it on GitHubhttps://github.com/huwenboshi/ImpG/issues/2#issuecomment-72135671.

De inhoud van dit bericht is vertrouwelijk en alleen bestemd voor de geadresseerde(n). Anderen dan de geadresseerde(n) mogen geen gebruik maken van dit bericht, het niet openbaar maken of op enige wijze verspreiden of vermenigvuldigen. Het UMCG kan niet aansprakelijk gesteld worden voor een incomplete aankomst of vertraging van dit verzonden bericht.

The contents of this message are confidential and only intended for the eyes of the addressee(s). Others than the addressee(s) are not allowed to use this message, to make it public or to distribute or multiply this message in any way. The UMCG cannot be held responsible for incomplete reception or delay of this transferred message.