search

huwwp / cryptop

command line crypto portfolio
MIT License
235 stars 41 forks source link

Thousands separator #38

Closed talisein closed 7 years ago

talisein commented 7 years ago

This pull request has 2 patches. The first simply adds a comma thousands separator to all numerical columns.

The second patch goes a little further, and employs locale to render the 'native' currency (e.g. USD) columns. A setting is added to config.ini to select an alternative locale.

huwwp commented 7 years ago

Yeah this is neater

mkoistinen commented 7 years ago

I can appreciate that not every region of the world displays numbers the same way, but this change renders cryptop useless for me, as I now only have 2 digits after the decimal point for the prices of various coins. Coins like SC is currently something like $0.00677, this just displays $0.01. We need to be able to declare how many digits to display again.

In fact, I don't care how many digits are displayed for the amount held, I know this already. Its the price data that is paramount for me.

huwwp commented 7 years ago

I'll take another pass at this, I've been busy so haven't had a chance recently