huwwp / cryptop

command line crypto portfolio
MIT License
236 stars 40 forks source link

Allow alternate to wallet.json? #43

Open jgoggan opened 6 years ago

jgoggan commented 6 years ago

It would be great to have a command-line option to specify either a different location for the wallet.json and config.ini files -- or just allow the actual files to be specified specifically. I sometimes want to track two different sets of coins. For example, I track the coins that I've purchased separately from the coins that I've mined. So, I'd prefer to run two copies of cryptop -- one showing purchased coins and one showing mined coins. It'd be great if I could just do something like:

$ cryptop --wallet mining.json

...and it would use that instead of "wallet.json" from my .cryptop folder.

Just a thought if someone wants to pick it up. If no one does, I'll add it later when I have some more time. Thanks!

derhornspieler commented 6 years ago

I 2nd the idea. Keep multiple instances open with different wallets.

derhornspieler commented 6 years ago

!/bin/bash

case $1 in 1) cp ~/.cryptop/wallet.json.1 ~/.cryptop/wallet.json cryptop cp ~/.cryptop/wallet.json ~/.cryptop/wallet.json.1 echo "wallet saved" ;;

2) cp ~/.cryptop/wallet.json.2 ~/.cryptop/wallet.json cryptop cp ~/.cryptop/wallet.json ~/.cryptop/wallet.json.2 echo "wallet saved" ;; esac

derhornspieler commented 6 years ago

@jgoggan quick little script will do just that.

jgoggan commented 6 years ago

That doesn't actively allow you to run and use multiple instances at the same time though. You'll incorrectly overwrite the wallet.json file from one with the other if you run both at the same time and make any changes.

derhornspieler commented 6 years ago

Ahh, thought you wanted just single instance with ability to change wallets. Yes, this script will not work for multiple instances of program.

Besides its having bug issues with floats on a lot of the alt coins. Hope this gets fixed soon!!

On Jan 8, 2018, at 2:45 PM, John notifications@github.com wrote:

That doesn't actively allow you to run and use multiple instances at the same time though. You'll incorrectly overwrite the wallet.json file from one with the other if you run both at the same time and make any changes.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/huwwp/cryptop/issues/43#issuecomment-356090819, or mute the thread https://github.com/notifications/unsubscribe-auth/AOh-T8e9vLd6JUrkqZBaXbu1bbdF_tAbks5tIn5hgaJpZM4PF7f1.

jgoggan commented 6 years ago

It's funny because you actually said "Keep multiple instances open with different wallets." and then "quick little script will do just that." So, I thought you were trying to do it with more than one open at a time too since that's what you said. :) In any case, yes, hopefully they fix some things soon -- and hopefully this gets added one day. It's on my list for when I have time, but I'm hoping someone else does it first. To be honest, I've already got a modified version running that just uses a different file already. So, for me, I'm running two copies and it works. But, it would be nice to have a real command-line for choosing a different wallet instead of just my hack.