search

huwwp / cryptop

command line crypto portfolio
MIT License
235 stars 41 forks source link

fix issue #54 by explicit conversion to float in get_price() #55

Closed Vindaar closed 6 years ago

Vindaar commented 6 years ago

Issue #54 was caused by the API calls after parsing the JSON data. In some cases this resulted in strings instead of floats (what cryptop expects). Thus, the TypeError was thrown due to float * str multiplication.

cschroeder23 commented 6 years ago

Tested out this branch and i am able to input coins that were previously not working. Thanks!!!!

miqlar commented 6 years ago

Tested the proposed changes, and it solves perfectly the issue.

andrew-morris commented 6 years ago

+1 confirmed this fix works

ghost commented 6 years ago

Tested install of this branch and fixed the error, works perfectly now.