Closed tha2015 closed 6 years ago
Merging #33 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage 23.56% 23.56%
Complexity 2508 2508
=========================================
Files 450 450
Lines 37631 37631
Branches 7028 7028
=========================================
Hits 8869 8869
Misses 27884 27884
Partials 878 878
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e2b322a...eac8ce6. Read the comment docs.
Did you verify that everything still works after building Lilith with your changes?
Please don't get me wrong: everything looks fine for me and thanks for your contribution. It's really appreciated. The only problem is that I have no Windows to double-check for myself.
Yes, I tested it on Windows under different situations:
Of course you have to be careful about the quality. That's why I like to use this tool and want to help to improve it.
OK, thanks again. :)
This commit fixes #32 Basically it will try to check JAVA_HOME, JAVA_EXE and PATH environment variables for java program