huxi / lilith

Lilith is a Logging- and AccessEvent viewer for Logback, log4j, log4j2 and java.util.logging
http://lilith.huxhorn.de
GNU Lesser General Public License v3.0
137 stars 18 forks source link

Fixes #32 - "Windows - Lilith 8.1.1 failed from Gradle" #33

Closed tha2015 closed 6 years ago

tha2015 commented 6 years ago

This commit fixes #32 Basically it will try to check JAVA_HOME, JAVA_EXE and PATH environment variables for java program

codecov[bot] commented 6 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage     23.56%   23.56%           
  Complexity     2508     2508           
=========================================
  Files           450      450           
  Lines         37631    37631           
  Branches       7028     7028           
=========================================
  Hits           8869     8869           
  Misses        27884    27884           
  Partials        878      878

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b322a...eac8ce6. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 25.904% when pulling eac8ce626cb6044f5137e0e688d0d189c7d15a86 on tha2015:LAUNCH_GRADLE into e2b322af158e5c4630046680fb07f1caeb6ea342 on huxi:master.

huxi commented 6 years ago

Did you verify that everything still works after building Lilith with your changes?

Please don't get me wrong: everything looks fine for me and thanks for your contribution. It's really appreciated. The only problem is that I have no Windows to double-check for myself.

tha2015 commented 6 years ago

Yes, I tested it on Windows under different situations:

  1. Only JAVA_HOME is set
  2. Only JAVA_EXE is set
  3. Both JAVA_HOME and JAVA_EXE are set
  4. None of JAVA_HOME or JAVA_EXE is set and javaw.exe is in PATH
  5. None of JAVA_HOME or JAVA_EXE is set and javaw.exe is NOT in PATH

Of course you have to be careful about the quality. That's why I like to use this tool and want to help to improve it.

huxi commented 6 years ago

OK, thanks again. :)